viro icon indicating copy to clipboard operation
viro copied to clipboard

3d object with rigged (Skeletal animation) doesn't work

Open fraviloria opened this issue 6 years ago • 19 comments

Environment

Development OS: Mac Version: ViroReact version: 2.15.0 React Native version: 0.60.3 Device(s): iPhone X, Xs Max, Xr, 6s plus, 7 iOS 12.3.1, Samsung s8, s8+, Note 8

Description

<Viro3DObject source={require('./res/animations.gltf')}
           resources={[require('./res/buffer.bin'),
                       require('./res/texture.png')]}
           position={[0.0, 0.0, -10]}
           scale={[0.1, 0.1, 0.1]}
           type=“GLTF”
           animation={{name:'Take 001',
                      run:true,
                      loop:true,
                     delay:1000}}
/>

The 3d object (GLTF and GLB) with rigged (Skeletal animation) doesn't work on ViroReact.

This is an example of the 3d object on GLTF (https://drive.google.com/file/d/1IFeCPc01BAoK4hxFC2Ow-4ULpoi3sKmm/view?usp=sharing)

fraviloria avatar Jul 23 '19 06:07 fraviloria

yes animated models glTF are not supported yet, you can use fbx.

Turtleted21 avatar Jul 23 '19 08:07 Turtleted21

@Turtleted21 the gLTF animated is work but my issue is gLTF with rigged (Skeletal animation).

@dam00n @radvani Please help me to verify this issue.

fraviloria avatar Jul 23 '19 16:07 fraviloria

Hey @fraviloria, thanks for reporting this, we are currently taking a look into this issue now.

dthian avatar Jul 23 '19 18:07 dthian

Hey @dthian , If you would like to get more detail about similar crash on android.

I am also trying to do same thing like playing gltf animation I have posted crash log https://github.com/viromedia/viro/issues/676

BMR11 avatar Jul 23 '19 22:07 BMR11

@BMR11 My gLTF load on Viro Camera isn't crashing, but without movement I mean static, @dthian is helping me about it

fraviloria avatar Jul 23 '19 22:07 fraviloria

Thanks @fraviloria for details but I am having same issue like my gltf animation is a rigged skeleton animation and I can preview it using https://gltf-viewer.donmccurdy.com/ properly.

Though I will create another issue in case your case may be different from mine.

BMR11 avatar Jul 24 '19 05:07 BMR11

@BMR11 that's correct, the gLTF work properly using this page (https://gltf-viewer.donmccurdy.com/), for that reason, I think that the problem is with ViroReact.

@dthian Do you have any update with it?

fraviloria avatar Jul 24 '19 17:07 fraviloria

ok I understand why animated model from Sketchfab don't work, because these are Skeletal animation. Tested this Turtle model: https://skfb.ly/6HGqp Don't work with ViroReact, work with viewer donmccurdy

Turtleted21 avatar Jul 25 '19 13:07 Turtleted21

don't work for me, sometimes no animation sometimes only few bones are animated model tested : https://skfb.ly/6H7Bp https://skfb.ly/6HqUw work with viewer donmccurdy

Turtleted21 avatar Aug 13 '19 11:08 Turtleted21

Hi @dthian with have the same issue, after the upgrade (v2.16.0) the GLTF with Skeletal animation load deformed or only few part are animated.

fraviloria avatar Aug 14 '19 00:08 fraviloria

Hey all, the v.2.16.0 upgrade fixed some skeletal animation issues but not all. This is a known bug. I'll update this bug soon as we've root caused and determined a fix.

dthian avatar Aug 14 '19 17:08 dthian

Is RN 0.60 supported anyway?

antoinerousseau avatar Aug 22 '19 10:08 antoinerousseau

Hi @dthian , I also have the same issue, is the gltf loading with skeletal animation issue fixed, any updates on this.

parul1986 avatar Aug 28 '19 07:08 parul1986

@dthian Any update on this?

mstrokin avatar Nov 20 '19 19:11 mstrokin

Hey @mstrokin have you verified if your model works with the latest build of viro? If it doesn't, unfortunately we are not providing dedicated support at this time, and have open-sourced the renderer, as mentioned.

Please feel free to take a stab at the bug, or to refer it to the community to be picked up.

dthian avatar Nov 20 '19 20:11 dthian

@dthian I haven't, sorry, we're using FBX-VRX files but I was researching if it's possible to swith to glTF and stumbled upon this issue (because we're using skeletal animation as well)

Will try to find spare time to test this next week.

P.S. Thanks a lot for open-sourcing this and kudos for a quick reply!

mstrokin avatar Nov 20 '19 20:11 mstrokin

Very nice how simple it is to load gltf files (just need to make sure textures and .bin files co-located in same relative folder location with the gltf in assets)

Unfortunately gltf skeletal animation still unsupported, seems from the comments above that further development may have been suspended

Viro: Removing mis-matching animation - layered skeletal animations not yet supported for gLTF.

tellypresence avatar Jun 15 '20 03:06 tellypresence

Actually, gltf skeletal animations are supported, just not layered ones unfortunately. It might be supported in FBX models though.

dthian avatar Jun 17 '20 15:06 dthian

We are currently blocked by this issue and wondering if there are any updates, or if others have been able to get around it while still using gLTF ( FBX is not an easy option for us) ? What exactly is meant by "layered animations" in this context? Does it refer to the usage of gLTF "skins" as defined in the specs? https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#skins

Versions: "@viro-community/react-viro": "^2.23.0", "react": "17.0.2", "react-native": "0.68.2"

byron-the-bulb avatar Sep 19 '22 21:09 byron-the-bulb