quill icon indicating copy to clipboard operation
quill copied to clipboard

Disable default bevy features for Quill

Open PROMETHIA-27 opened this issue 1 year ago • 5 comments

Now vortex should be working.

PROMETHIA-27 avatar Aug 12 '24 21:08 PROMETHIA-27

One moment, the revert means it seems like the original changes aren't here, I'll see if I can revert-revert

PROMETHIA-27 avatar Aug 12 '24 21:08 PROMETHIA-27

Ok, everything should be prepared again I think.

PROMETHIA-27 avatar Aug 12 '24 21:08 PROMETHIA-27

:+1: this change! Build size is a big concern for my app. On that topic, one thing that I'd like to contribute (if you think it's appropriate @viridia) would be making bevy_ui an optional default in bevy_quill_core. However if you don't want to deal with maintenance burden I'm happy to do this in a fork.

connorgmeehan avatar Aug 27 '24 23:08 connorgmeehan

I'm open to this; the original PR had some compatibility issues and I haven't gotten around to testing/rebasing the new one - been a bit distracted lately.

Separating bevy_quill_core from bevy_ui might be a challenge. It's kind of hard to tell how bad the dependencies are due to how many places I import bevy::prelude.

viridia avatar Aug 28 '24 00:08 viridia

The place where Quill core depends on bevy_ui the most is the dependency path that runs through bevy_mod_stylebuilder. You'd basically have to make styles an optional feature or something.

viridia avatar Aug 28 '24 00:08 viridia