Virgil Chan
Virgil Chan
> Could you please add tests and an entry under the 1.6 changelogs? All tests have passed and it's ready for review. Thank you for your time!
> Thanks for the updates @virchan. > > The Cuda tests are not passing for `root_mean_squared_log_error` probably because it calls `root_mean_squared_error` which currently does not support the array api. >...
> **Note**: I haven't checked with the **mps** device because a Mac setup is needed for that. > > @virchan if you are working on a Mac can you test...
Thank you for your time!
> So I think that the functions relying on the `percentile` or `_weighted_percentile` function cannot be implemented for the moment. TL;DR: I've reverted the metrics. Thank you for catching that!...
Thanks for the updates @OmarManzoor! It's ready for a second review!
Thank you for the follow-up, @OmarManzoor! I have updated the `explained_variance_score` function, and the CUDA test looks fine locally. Could you please run it again on your end?
Thank you everyone for your time!
[ ] [Train error vs Test error example](https://scikit-learn.org/dev/auto_examples/model_selection/plot_train_error_vs_test_error.html) is really similar to [Plotting Validation Curves example](https://scikit-learn.org/stable/auto_examples/model_selection/plot_validation_curve.html). I'd like to work on this part, if it's available. Edit: Merged.
I think what's outlined in LTS is consistent with what scikit-learn is doing in scikit-learn/scikit-learn#30888. So I would like to ping @lesteve and @lucascolley to see if they have any...