vircadia-native-core icon indicating copy to clipboard operation
vircadia-native-core copied to clipboard

Fix flow not working without gravity C++Flow

Open JulianGro opened this issue 5 years ago • 9 comments

When trying to use the "flow" system to make stuff floppy, the bones just kind of fly around wildly rather than staying in their origin position when no gravity force is applied. An example is this avatar: http://94.130.177.235/Effole22Cpp/Effole22.fst Here is a video of the problem: http://94.130.177.235/Effole22Cpp/cppflow.webm Playing around with the settings, there is no workaround. This also happens on the old javascript flow.

Here is an example of how it should behave without gravity: http://94.130.177.235/Effole22Cpp/cppflow_vrc.webm Obviously always depending on the values for stiffness, etc.

JulianGro avatar Jul 18 '20 16:07 JulianGro

~~I am putting up a bounty of 100$ for now.~~

JulianGro avatar Jul 18 '20 19:07 JulianGro

David is investigating the C++ flow integration in general and will report back with findings of feasibility.

two-one-five avatar Jul 18 '20 19:07 two-one-five

It looks like the C++ flow code is in generally good shape and it should be feasible to fix for such a bounty. I can take this on.

ctrlaltdavid avatar Jul 19 '20 21:07 ctrlaltdavid

I'm pausing work on this for the moment. While the code in general seems OK there are some inexplicable bits and I've not been able to work solve the problem so far. The rotation of the first joint in zero g seems especially problematic.

ctrlaltdavid avatar Jul 21 '20 20:07 ctrlaltdavid

Note: Kalila has to reload her avatar on launch in order to not have her hair hover around.

ctrlaltdavid avatar Oct 18 '20 21:10 ctrlaltdavid

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 27 '21 19:03 stale[bot]

Note: The old, pre-C++ implementation of flow in JavaScript reportedly worked well. https://hifi-content.s3.amazonaws.com/jimi/avatar/Niconico/Jene_5/scripts/jene_Flow.js

See, also: https://github.com/vircadia/vircadia/issues/74

ctrlaltdavid avatar Apr 03 '21 22:04 ctrlaltdavid

Hello! Is this still an issue?

stale[bot] avatar Mar 03 '22 20:03 stale[bot]

Hello! Is this still an issue?

stale[bot] avatar Sep 20 '22 16:09 stale[bot]