vircadia-native-core Fixed crash reporting U.X.

#1484 I obviously can't test this so hopefully it works.

Also rephrased toolbar setting to match tablet app and made a slight change to app setting text.

Dec 02 '21 07:12 Penguin-Guru

Note that this is designed to de-sync the app setting display from the toolbar setting (and actual setting saved), to reflect the actual behaviour without changing the saved setting. This means it is possible for a user to compile without crash reporting, believe that their crash reporting setting is disabled based on the app U.I., port their settings over to a build that does support crash reporting, and have their crash reports surprisingly submitted. This is not ideal but it seems like a fringe case and is largely eliminated if the default value is unchecked. I designed it like this to prevent the case where the setting is disabled and checked, which would suggest that crash reporting is functional and can not be turned off. I couldn't think of another good way to communicate that the functionality is disabled. Maybe a tool-tip saying "if checkbox is disabled, functionality is too"? That seems a bit rough though. Including it in the text description also seems rough.

This would be less of an issue with a tool-tip but disabled checkboxes look almost identical to enabled checkboxes when using the dark theme (#1508). I'm not confident enough in my artistic skills to edit the theme(s).

Dec 02 '21 08:12 Penguin-Guru

The following links are available: build (macOS-10.15, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-Interface-PR1507-b8a2c8c-_8cd0ca5d.dmg

build (macOS-10.15, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-b8a2c8c-_8cd0ca5d.dmg

build (ubuntu-18.04, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-b8a2c8c-.tar_8cd0ca5d.Z
https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-b8a2c8c-_8cd0ca5d.sh
https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-b8a2c8c-.tar_8cd0ca5d.gz

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-b8a2c8c-_8cd0ca5d.exe

build (self-hosted_debian-11_aarch64, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-b8a2c8c-.tar_8cd0ca5d.gz
https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-b8a2c8c-.tar_8cd0ca5d.Z
https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-b8a2c8c-_8cd0ca5d.sh

Dec 02 '21 09:12 vircadia-build-notifier

I have the tool-tip mostly set up but I'm starting to think it would be better to not disable anything and just add some kind of warning icon with a tool-tip near the affected checkbox when the functionality is disabled. A dark red exclamation mark in a ring border comes to mind but I don't really want to make that and figure out how to add it to the Q.M.L. Maybe I will tomorrow.

Dec 03 '21 09:12 Penguin-Guru

I have the tool-tip mostly set up but I'm starting to think it would be better to not disable anything and just add some kind of warning icon with a tool-tip near the affected checkbox when the functionality is disabled.

There has to be a warning symbol floating around. A white triangle with an exclamation mark in it. It's used in the asset browser when there is an issue. And yeah I definitely like that a lot more than disabling things.

Dec 03 '21 17:12 JulianGro

Ok. I'll give it a shot.

Dec 03 '21 17:12 Penguin-Guru

Unfortunately, I lost my motivation to work on this. I'm going to push what I was working on so someone can fix the bugs or close this P.R.

Bugs were:

ToolTip opacity not being set when I attempted to hover.
Positioning of tooltip text was not what I wanted.

There may be more efficient ways of adding the warning to the Q.M.L. I had not yet fully explored that.

Dec 03 '21 21:12 Penguin-Guru

The following links are available: build (macOS-10.15, client)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-Interface-PR1507-718f6d9-_e82e6ae6.dmg

build (macOS-10.15, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-718f6d9-_e82e6ae6.dmg

build (ubuntu-18.04, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-718f6d9-.tar_e82e6ae6.gz
https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-718f6d9-_e82e6ae6.sh
https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-718f6d9-.tar_e82e6ae6.Z

build (windows-latest, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-718f6d9-_e82e6ae6.exe

build (self-hosted_debian-11_aarch64, full)

https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-718f6d9-.tar_e82e6ae6.gz
https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-718f6d9-.tar_e82e6ae6.Z
https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1507/Vircadia-PR1507-718f6d9-_e82e6ae6.sh

Dec 04 '21 02:12 vircadia-build-notifier

Hello! Is this still an issue?

Jun 18 '22 01:06 stale[bot]