vircadia-native-core icon indicating copy to clipboard operation
vircadia-native-core copied to clipboard

Update env variables and protocol.

Open digisomni opened this issue 4 years ago • 18 comments

digisomni avatar Mar 29 '21 06:03 digisomni

The following links are available: build (ubuntu-18.04, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-0a87dfb-_eb7cad00.sh
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-0a87dfb-.tar_eb7cad00.Z
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-0a87dfb-.tar_eb7cad00.gz

build (macOS-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-0a87dfb-_eb7cad00.dmg

build (ubuntu-18.04, android)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-0a87dfb_eb7cad00.apk
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-Quest-Alpha-PR1130-0a87dfb_eb7cad00.apk

build (windows-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-0a87dfb-_eb7cad00.exe

vircadia-build-notifier avatar Mar 29 '21 07:03 vircadia-build-notifier

Do you consider this a necessary change? I consider it a unnecessary one that will cause problems in future with both using the vircadia name and compatibility with previous and feature forks. But if you feel this is absolutely necessary I suggest we change them to something that does not have vircadia in name to make it easier to identify what has been added to be different from the base code.

vegaslon avatar Mar 29 '21 16:03 vegaslon

It's just more of the hifi-migration and branding. It helps because for example if you're using a High Fidelity version or an older build then the functionality can be separated out. You can define how you want High Fidelity VR to work or its successor "Vircadia" as we've changed a lot since then and continue to improve the system.

digisomni avatar Mar 29 '21 20:03 digisomni

I think this can be done over time. For instance I think my #1127 may yet acquire an improvement for which it would make sense to change how the setting works. At that point, might as well rename it, since it'll be incompatible anyway.

daleglass avatar Mar 29 '21 20:03 daleglass

I think a case can be made that a change like this is not so much about branding and more about “becouse we can”, changing the variables to something specific means that the variable will have to be replicated for each fork working on as they each grow. Leaving you with a lot of environmental variable that all do the exact same thing. As dale says until they each start differing in functionality from one fork to another there is really no reason to change them out of the blue.

vegaslon avatar Mar 29 '21 20:03 vegaslon

The thing is that we have new developers joining up to work with Vircadia all the time. As such, they will eventually have to change it. It's easier to change things that will inevitably have to change later, now, rather than later.

e.g. breaking parts of the scripting API now would be better than breaking it later if at all possible because the trouble later is much greater.

That's why I'd rather get developers used to using the correct variable now.

If you have multiple installs on your computer/server then the worst that will happen is having +1 entry, a minor inconvenience. The benefit in this case is that future developers can code/implement with the mind that these are not liable to change.

digisomni avatar Mar 29 '21 20:03 digisomni

Still prefer they not ended up with vircadia in name none the less. It makes them too long to view in some env variable viewers.

vegaslon avatar Mar 29 '21 21:03 vegaslon

Still prefer they not ended up with vircadia in name none the less. It makes them too long to view in some env variable viewers.

Do you know the specific character limits? Can try to figure out a good abbreviation.

digisomni avatar Mar 29 '21 21:03 digisomni

Suggest “vir” or “virc”. That would leave no trouble.

vegaslon avatar Mar 29 '21 21:03 vegaslon

Hmm, I already used VIRCADIA_ elsewhere

daleglass avatar Mar 29 '21 21:03 daleglass

Sorry did not catch that earlier.. in this case it would just display as a huge block of vircadia in the viewers, and hence have to open each variable separately to find the correct one to edit.

vegaslon avatar Mar 29 '21 21:03 vegaslon

The following links are available: build (ubuntu-18.04, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-98714e3-.tar_21367b21.Z
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-98714e3-.tar_21367b21.gz
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-98714e3-_21367b21.sh

build (macOS-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-98714e3-_21367b21.dmg

build (windows-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-98714e3-_21367b21.exe

build (ubuntu-18.04, android)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-Quest-Alpha-PR1130-98714e3_21367b21.apk
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-98714e3_21367b21.apk

vircadia-build-notifier avatar Apr 16 '21 08:04 vircadia-build-notifier

Note that the packaging scripts at https://github.com/vircadia/vircadia/blob/master/pkg-scripts/new-server will need to be adjusted with this.

odysseus654 avatar May 02 '21 21:05 odysseus654

I'll do another ctrl+f for that stuff before it's time to mergerino.

digisomni avatar May 02 '21 23:05 digisomni

The following links are available: build (ubuntu-18.04, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-77adfbe-.tar_26fb5172.gz
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-77adfbe-.tar_26fb5172.Z
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-77adfbe-_26fb5172.sh

build (macOS-latest, client)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-Interface-PR1130-77adfbe-_26fb5172.dmg

build (macOS-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-77adfbe-_26fb5172.dmg

build (windows-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-77adfbe-_26fb5172.exe

build (ubuntu-18.04, android)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-77adfbe_26fb5172.apk
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-Quest-Alpha-PR1130-77adfbe_26fb5172.apk

vircadia-build-notifier avatar Jun 02 '21 21:06 vircadia-build-notifier

The following links are available: build (ubuntu-18.04, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-59d2182-.tar_5db189bb.gz
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-59d2182-_5db189bb.sh
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-59d2182-.tar_5db189bb.Z

build (macOS-latest, client)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-Interface-PR1130-59d2182-_5db189bb.dmg

build (macOS-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-59d2182-_5db189bb.dmg

build (windows-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-59d2182-_5db189bb.exe

build (ubuntu-18.04, android)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-PR1130-59d2182_5db189bb.apk
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1130/Vircadia-Quest-Alpha-PR1130-59d2182_5db189bb.apk

vircadia-build-notifier avatar Jun 21 '21 10:06 vircadia-build-notifier

Hello! Is this still an issue?

stale[bot] avatar Apr 28 '22 15:04 stale[bot]

Hello! Is this still an issue?

stale[bot] avatar Apr 19 '23 13:04 stale[bot]