vircadia-native-core icon indicating copy to clipboard operation
vircadia-native-core copied to clipboard

Initial audit logging, for review.

Open digisomni opened this issue 5 years ago • 10 comments

Before I break it out into its own class and all that jazz (if I should even...), I'd like to know if this is relatively performant or would be, what better ways can I do this? I also wanted to do a push of changed properties each time. However that requires looping and that adds more overhead.

Now this can be good for general times when rapid edits aren't necessary, but would like to know if this is/can be performant enough for general use running in the background too.

digisomni avatar Feb 07 '21 07:02 digisomni

The following links are available: build (windows-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b65d358_5d43fadc.exe

vircadia-build-notifier avatar Feb 07 '21 08:02 vircadia-build-notifier

The following links are available: build (macOS-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0_47079106.dmg

build (ubuntu-18.04, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0.tar_47079106.Z
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0_47079106.sh
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0.tar_47079106.gz

build (ubuntu-18.04, android)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0_47079106.apk
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-Quest-Alpha-PR1006-94c70c0_47079106.apk

build (windows-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0_47079106.exe

vircadia-build-notifier avatar Feb 08 '21 13:02 vircadia-build-notifier

The following links are available: build (ubuntu-18.04, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e.tar_998616fd.gz
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e_998616fd.sh
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e.tar_998616fd.Z

build (macOS-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e_998616fd.dmg

build (windows-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e_998616fd.exe

build (ubuntu-18.04, android)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-Quest-Alpha-PR1006-4e1508e_998616fd.apk
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e_998616fd.apk

vircadia-build-notifier avatar Feb 11 '21 02:02 vircadia-build-notifier

The following links are available: build (ubuntu-18.04, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572.tar_45a629d3.gz
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572.tar_45a629d3.Z
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572_45a629d3.sh

build (macOS-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572_45a629d3.dmg

build (ubuntu-18.04, android)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572_45a629d3.apk
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-Quest-Alpha-PR1006-329c572_45a629d3.apk

build (windows-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572_45a629d3.exe

vircadia-build-notifier avatar Feb 11 '21 08:02 vircadia-build-notifier

image

digisomni avatar Feb 18 '21 22:02 digisomni

this is a threading issue: the problem in the above image is that the isProcessorRunning method is being called on an object that has been destroyed, likely triggered from a different thread. you can see in the log that a thread was stopped just before the crash

HifiExperiments avatar Feb 19 '21 20:02 HifiExperiments

Notes: I should fold the terse edit logging into this somehow as an extra option applied to this.

digisomni avatar Mar 04 '21 22:03 digisomni

Further notes: will not combine terse edit logging into this PR because terse may very well be useful for debugging purposes.

Gotta fix the crash still.

digisomni avatar Mar 18 '21 21:03 digisomni

The following links are available: build (ubuntu-18.04, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7-_d2a319b5.sh
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7-.tar_d2a319b5.gz
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7-.tar_d2a319b5.Z

build (macOS-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7-_d2a319b5.dmg

build (windows-latest, full)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7-_d2a319b5.exe

build (ubuntu-18.04, android)

  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7_d2a319b5.apk
  • https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-Quest-Alpha-PR1006-b7e3cc7_d2a319b5.apk

vircadia-build-notifier avatar Mar 19 '21 13:03 vircadia-build-notifier

Hello! Is this still an issue?

stale[bot] avatar Jun 18 '22 01:06 stale[bot]