Initial audit logging, for review.
Before I break it out into its own class and all that jazz (if I should even...), I'd like to know if this is relatively performant or would be, what better ways can I do this? I also wanted to do a push of changed properties each time. However that requires looping and that adds more overhead.
Now this can be good for general times when rapid edits aren't necessary, but would like to know if this is/can be performant enough for general use running in the background too.
The following links are available: build (windows-latest, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b65d358_5d43fadc.exe
The following links are available: build (macOS-latest, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0_47079106.dmg
build (ubuntu-18.04, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0.tar_47079106.Z
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0_47079106.sh
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0.tar_47079106.gz
build (ubuntu-18.04, android)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0_47079106.apk
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-Quest-Alpha-PR1006-94c70c0_47079106.apk
build (windows-latest, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-94c70c0_47079106.exe
The following links are available: build (ubuntu-18.04, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e.tar_998616fd.gz
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e_998616fd.sh
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e.tar_998616fd.Z
build (macOS-latest, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e_998616fd.dmg
build (windows-latest, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e_998616fd.exe
build (ubuntu-18.04, android)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-Quest-Alpha-PR1006-4e1508e_998616fd.apk
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-4e1508e_998616fd.apk
The following links are available: build (ubuntu-18.04, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572.tar_45a629d3.gz
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572.tar_45a629d3.Z
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572_45a629d3.sh
build (macOS-latest, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572_45a629d3.dmg
build (ubuntu-18.04, android)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572_45a629d3.apk
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-Quest-Alpha-PR1006-329c572_45a629d3.apk
build (windows-latest, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-329c572_45a629d3.exe

this is a threading issue: the problem in the above image is that the isProcessorRunning method is being called on an object that has been destroyed, likely triggered from a different thread. you can see in the log that a thread was stopped just before the crash
Notes: I should fold the terse edit logging into this somehow as an extra option applied to this.
Further notes: will not combine terse edit logging into this PR because terse may very well be useful for debugging purposes.
Gotta fix the crash still.
The following links are available: build (ubuntu-18.04, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7-_d2a319b5.sh
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7-.tar_d2a319b5.gz
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7-.tar_d2a319b5.Z
build (macOS-latest, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7-_d2a319b5.dmg
build (windows-latest, full)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7-_d2a319b5.exe
build (ubuntu-18.04, android)
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-PR1006-b7e3cc7_d2a319b5.apk
- https://athena-public.s3.eu-west-3.amazonaws.com/builds/PR/vircadia_vircadia/PR1006/Vircadia-Quest-Alpha-PR1006-b7e3cc7_d2a319b5.apk
Hello! Is this still an issue?