Viraz Malhotra comments

Results 27 comments of


                                            Viraz Malhotra

chore: update events

adding some more context here, regarding updating the L2 bridge, I made the event update as an optional update as this would result in updating the [watchtower event struct](https://github.com/FuelLabs/fuel-canary-watchtower/blob/b643c9b81c82da241401bcde6f912b1f036b2200/packages/infrastructure/src/adapters/fuel_chain_adapter.rs#L20)

Error: `Define an initializer function and use it to call the initializers of parent contracts`

hey @vladimir-trifonov I am getting a similar issue #1124, do you remember which version of the `@openzeppelin/hardhat-upgrades` package did `@openzeppelin/upgrades-core v1.41.0` pointed too ?

Error: `Define an initializer function and use it to call the initializers of parent contracts`

hmm I had `initialize` defined before and it was working fine but for some reason now it doesn't since last week or so which is super weird

immutable for libraries / dynamic libraries / high-level delegatecall

on first thought as a solidity dev I believe for a contract using multiple libraries would need to have all those libraries deployed first before deploying the contract right might...

refactor: update rate limit params unconditionally when rate limit is reset

commits to review - https://github.com/FuelLabs/fuel-bridge/pull/308/commits/1626348322a5401f4411f2b700a4e4bda1310d69 - https://github.com/FuelLabs/fuel-bridge/pull/308/commits/aa068f88396bfe66d89ce717210bbecbeb3f6aa2 - https://github.com/FuelLabs/fuel-bridge/pull/308/commits/4ab621b18b306b93525b4127790887948cb182bb

refactor: update rate limit params unconditionally when rate limit is reset

we updated our docs to explain the mechanism of the `resetRateLimit` method and decided not to merge this so closing for now

bug(`forge coverage`): stack too deep when using `--ir-minimum` and coverage report is not accurate

Hi @grandizzy has there been any progress regarding this ?