nh icon indicating copy to clipboard operation
nh copied to clipboard

Test nix-darwin in CI

Open viperML opened this issue 1 year ago • 7 comments

I need you to set this up @ToyVo

viperML avatar Nov 26 '24 07:11 viperML

It should be a new step after the build in build.yaml that calls nh darwin build ...

viperML avatar Nov 26 '24 07:11 viperML

I will take a look at this this weekend / holiday

ToyVo avatar Nov 26 '24 23:11 ToyVo

Anything else that we are missing to test or is this issue completed?

Eveeifyeve avatar Dec 20 '24 21:12 Eveeifyeve

I have no plans for more on this issue

ToyVo avatar Dec 20 '24 23:12 ToyVo

I feel like the testing could be a bit better I feel like we should use the tests directory to run tests for nix-darwin or at least include a test.rs file then it runs the comamnds that are needed to test for.

Eveeifyeve avatar Jan 13 '25 07:01 Eveeifyeve

Ima try and fix all of the issues so we can get 4.0 under away since it's been 5 months.

Eveeifyeve avatar Apr 13 '25 07:04 Eveeifyeve

~Well sadly I have to update the minium rust version for dev-dependacies for assert-cmd which should be a good test for darwin and nixos and will solve having to test manually in ci.~ UPDATE: nvm it turns out it doesn't change any minium version but sept for clap doesn't work until a certain version

Eveeifyeve avatar Apr 13 '25 17:04 Eveeifyeve