Violeta Georgieva
Violeta Georgieva
@yanwenliang You closed the issue?
@yanwenliang Yes this time the issue is different. I'm going to prepare one PR and will ask you to test it.
@yanwenliang Actually can you try the same file https://github.com/spring-cloud/spring-cloud-gateway/blob/62e0f241d2aac61e699e4733ff2ed46c6865b045/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/NettyWriteResponseFilter.java#L124 `if (connection != null) {`
@yanwenliang Can you add logs here https://github.com/spring-cloud/spring-cloud-gateway/blob/62e0f241d2aac61e699e4733ff2ed46c6865b045/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/NettyWriteResponseFilter.java#L102 https://github.com/spring-cloud/spring-cloud-gateway/blob/62e0f241d2aac61e699e4733ff2ed46c6865b045/spring-cloud-gateway-server/src/main/java/org/springframework/cloud/gateway/filter/NettyWriteResponseFilter.java#L69
> @violetagg , > > apart from CodeQL, I think this PR is ready for a second review. I will see tomorrow what to do for CodeQL. thank you. No...
> Any news regarding this? this is still to be fixed
I'm closing this issue as it is Netty related.
@yuzawa-san Please provide a PR so that we can discuss the changes. Thanks!
I'm closing this. When there is a solution in Netty and if we need to adapt something, we can reopen this issue.
@fokion Yes sure. Thanks! May be start experimenting with `main` branch (1.1.x version) as a base, because it will be hard with `netty5` branch (2.0.x)