Violeta Georgieva
Violeta Georgieva
I mean I don't see why we want to create this object every time, basically `QueryStringDecoder` holds mostly the same information as our HttpServerOperations, isn't it?
> another option is to bring in decodeParams codes from Netty into HttpOperations. Since decodeParams is trivial relative to other logics, perhaps we can just bring in the function into...
> @violetagg it looks like Netty folks are not keen on exposing decodeParams as public API. Let's go with bringing the codes into this project's codebase? what do you think?...
> @violetagg it looks like Netty folks are not keen on exposing decodeParams as public API. Let's go with bringing the codes into this project's codebase? what do you think?...
> checkNotNull and checkPositive are Netty utility methods. Do we have equivalent methods? I'll also bring in the unit test and modify it to suit our needs. Something like this...
> @violetagg I've finally go time to pick this up again. the PR failed the API compatibility check because one new method was added to the HttpServerRequest interface. What should...
@jchenga Can you please rebase?
> Hi @violetagg I rebased the feature branch on main and some checks failed. Looking at the errors, I don't think the issue is related to the change in the...
@yuzawa-san I'm gonna take a look at this
@yuzawa-san I'm gonna review this for 1.0.33