vinyldns
vinyldns copied to clipboard
Added record type sort in manage zones tab
Fixes #541.
Changes in this pull request:
- Added sort(Ascending and descending) for record type column in Manage records tab.
- Added sort for record type in API. (
/recordsets?maxItems=100&recordTypeSort=asc) .
Note :- Sort cannot applies for both record type and record name simultaneously . if record type sort is applied, record name sort will be ignored.
Codecov Report
Patch coverage: 95.65% and project coverage change: +0.01 :tada:
Comparison is base (
e062114) 92.24% compared to head (7ed8d0e) 92.25%.
Additional details and impacted files
@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
+ Coverage 92.24% 92.25% +0.01%
==========================================
Files 176 176
Lines 7646 7660 +14
Branches 224 213 -11
==========================================
+ Hits 7053 7067 +14
Misses 593 593
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ldns/api/domain/record/RecordSetCacheService.scala | 0.00% <0.00%> (ø) |
|
| .../vinyldns/api/domain/record/RecordSetService.scala | 92.92% <100.00%> (+0.02%) |
:arrow_up: |
| ...cala/vinyldns/api/domain/zone/ZoneViewLoader.scala | 94.44% <100.00%> (+0.32%) |
:arrow_up: |
| ...ain/scala/vinyldns/api/route/DnsJsonProtocol.scala | 99.19% <100.00%> (+<0.01%) |
:arrow_up: |
| ...in/scala/vinyldns/api/route/RecordSetRouting.scala | 97.36% <100.00%> (+0.09%) |
:arrow_up: |
| ...ldns/core/domain/record/ListRecordSetResults.scala | 100.00% <100.00%> (ø) |
|
| ...sql/repository/MySqlRecordSetCacheRepository.scala | 87.68% <100.00%> (+0.08%) |
:arrow_up: |
| ...ns/mysql/repository/MySqlRecordSetRepository.scala | 97.75% <100.00%> (+0.01%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
API looks good locally, but sorting in the manage records tab in the portal doesn't work for me. I'm able to click the Type column, but nothing happens, and I don't see the arrow icon like for the Name column. See screenshot
Can you please double check the same once. I could see the sort arrow icon in type field.

