Allow Super Users to Update Record Owner Group in Shared Zone
Fixes #644
Changes in this pull request: Super users can now update a record's owner group in a shared zone if the owner group is the only attribute being changed. This prevents super users from having to add themselves to a group temporarily to make that update.
Codecov Report
Base: 92.10% // Head: 92.10% // Increases project coverage by +0.00% :tada:
Coverage data is based on head (
f3bcb1c) compared to base (0b99d81). Patch coverage: 100.00% of modified lines in pull request are covered.
:exclamation: Current head f3bcb1c differs from pull request most recent head 680df86. Consider uploading reports for the commit 680df86 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #1174 +/- ##
========================================
Coverage 92.10% 92.10%
========================================
Files 173 172 -1
Lines 7395 6957 -438
Branches 197 174 -23
========================================
- Hits 6811 6408 -403
+ Misses 584 549 -35
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...vinyldns/api/domain/access/AccessValidations.scala | 98.68% <100.00%> (+0.01%) |
:arrow_up: |
| ...ldns/api/domain/batch/BatchChangeValidations.scala | 97.74% <100.00%> (-0.06%) |
:arrow_down: |
| .../vinyldns/api/domain/record/RecordSetService.scala | 90.76% <100.00%> (-1.98%) |
:arrow_down: |
| ...yldns/api/domain/record/RecordSetValidations.scala | 95.86% <100.00%> (-1.26%) |
:arrow_down: |
| ...ain/scala/vinyldns/mysql/TransactionProvider.scala | 62.06% <0.00%> (-2.45%) |
:arrow_down: |
| ...ldns/api/domain/membership/MembershipService.scala | 94.77% <0.00%> (-1.75%) |
:arrow_down: |
| ...nyldns/api/domain/batch/BatchChangeConverter.scala | 98.30% <0.00%> (-1.70%) |
:arrow_down: |
| .../main/scala/vinyldns/core/task/TaskScheduler.scala | 88.88% <0.00%> (-1.12%) |
:arrow_down: |
| ... and 58 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.