hashids icon indicating copy to clipboard operation
hashids copied to clipboard

Published 20 hours ago • verified publisher icon vinkla

Version 5.0

Open vinkla opened this issue 2 years ago • 3 comments

This pull request is work in progress on the next major version of the package. I would say the package is feature complete and we should probably only add syntactic sugar such as type hints. I think we should probably stop supporting PHP 7 at some point. This PR is currently a playground for whatever idea comes to mind. Since this package is used by a lot of developers I want to hear what the community have to say. What can we improve?

vinkla avatar Jun 28 '22 14:06 vinkla

Type hinting and php 7 drop are welcome addictions for a major version

ludo237 avatar Jul 07 '22 10:07 ludo237

Same here, this new version is really welcome.

I would advise adding a compatibility table in the README file to help people quickly decide what version they should be using.

machour avatar Jul 20 '22 11:07 machour

These are the current changes in this pull request:

  • Added property type declarations
  • Removed HashidsException class
  • Removed PHP 7 and 8.0 support
  • Renamed Bc class to BCMath

I was thinking about adding type hints to the math interface but bcmath and gmp behaves differently.

vinkla avatar Aug 28 '22 18:08 vinkla