inspirational-quotes icon indicating copy to clipboard operation
inspirational-quotes copied to clipboard

Published 20 hours ago • verified publisher icon vinitshahdeo

Adding yaml and initiating travis to automatically check JSON format for every pull request.

Open ay2306 opened this issue 4 years ago • 4 comments

There are many pending pull requests. We can initiate Travis to directly check if PR has the correct JSON format or not.

ay2306 avatar Sep 19 '20 19:09 ay2306

@ay2306 I've created #818 to address this request The benefit of Github Actions for this use case as there is no need to set up anything outside of Github. The drawback is that I think it won't run for existing PRs as there is a need to rebase it on top of .github/workflows config. It is not a problem to add jsonschema there to validate data.json content (list of dicts w/ specific fields)

kusha avatar Sep 20 '20 18:09 kusha

@kusha Yes, I am looking into it since yesterday and I couldn't find a way to run tests for the previous PRs.

ay2306 avatar Sep 20 '20 19:09 ay2306

is this still open? I don't see any active actions running on this repository and I've set this up before - I can get it setup to run on-demand for PRs.

MattRudy avatar Oct 16 '21 05:10 MattRudy

is this still open? I don't see any active actions running on this repository and I've set this up before - I can get it setup to run on-demand for PRs.

did this get assigned?

johnemurphy1 avatar Dec 30 '21 22:12 johnemurphy1