Water-Monitoring-System icon indicating copy to clipboard operation
Water-Monitoring-System copied to clipboard

Combine const declarations in server.js

Open first-timers[bot] opened this issue 4 years ago • 24 comments

🆕🐥☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

About First Timers Only.

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • [ ] 🙋 Claim this issue: Comment below.

    Once claimed we add you as contributor to this repository.

  • [ ] 👌 Accept our invitation to this repository. Once accepted, assign yourself to this issue

  • [ ] 📝 Update the file api/server.js in the Water-Monitoring-System repository (press the little pen Icon) and edit the line as shown below.

@@ -1,12 +1,12 @@
-const express = require("express");
-const mongoose = require("mongoose");
-const bodyParser = require("body-parser");
-const cors = require("cors");
-const helmet = require("helmet");
-const morgan = require("morgan");
-const config = require("config");
-const app = express();
-const port = process.env.PORT || 8080;
+const express = require("express"),
+    mongoose = require("mongoose"),
+    bodyParser = require("body-parser"),
+    cors = require("cors"),
+    helmet = require("helmet"),
+    morgan = require("morgan"),
+    config = require("config"),
+    app = express(),
+    port = process.env.PORT || 8080;
 
 //Use the database uri from the ./config directory
 const dbURI = config.dbURI;
  • [ ] 💾 Commit your changes

  • [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

first-timers[bot] avatar Feb 29 '20 10:02 first-timers[bot]

I want to take this issue @vinitshahdeo .

Swarnimashukla avatar Feb 29 '20 11:02 Swarnimashukla

I would like to take the issue, can you assign me this?

shibam17 avatar Feb 29 '20 14:02 shibam17

@vinitshahdeo I would like to take this issue.

ashishnagpal2498 avatar Feb 29 '20 18:02 ashishnagpal2498

I would like to take the issue, can you assign me this?

shibam17 avatar Feb 29 '20 18:02 shibam17

@jainpawan21 can I take this issue. I am very interested!

huonggiangbui avatar Mar 01 '20 07:03 huonggiangbui

@Swarnimashukla @soulhunter10737 @ashishnagpal2498 This issue is only for first-timers. Sorry, I cannot assign it to you guys.

vinitshahdeo avatar Mar 02 '20 08:03 vinitshahdeo

@huonggiangbui Assigning this issue to you. Expecting the PR by Tuesday, EOD.

vinitshahdeo avatar Mar 02 '20 08:03 vinitshahdeo

@vinitshahdeo thanks! but i cannot find the file "api/server.js". Is there any problem?

huonggiangbui avatar Mar 02 '20 09:03 huonggiangbui

@huonggiangbui Please checkout feature/backend-node branch. It's not available in master.

vinitshahdeo avatar Mar 02 '20 10:03 vinitshahdeo

Hey, I want to work on this issue

shreyakapoor08 avatar Mar 02 '20 15:03 shreyakapoor08

@shreyakapoor08 Hey sorry, I've already assigned this issue to @huonggiangbui.

vinitshahdeo avatar Mar 02 '20 15:03 vinitshahdeo

@shreyakapoor08 Will you be available to take #32 issue?

vinitshahdeo avatar Mar 02 '20 17:03 vinitshahdeo

@vinitshahdeo yes i will work on issue #32 . Kindly assign me that.

shreyakapoor08 avatar Mar 02 '20 18:03 shreyakapoor08

Hi, Please assign me this issue. I would like to work on it if he/she fails.

Adyasha8105 avatar Mar 03 '20 18:03 Adyasha8105

@vinitshahdeo can this issue be closed right now?

huonggiangbui avatar Mar 05 '20 18:03 huonggiangbui

Will close this once it's merged into master.

vinitshahdeo avatar Mar 05 '20 21:03 vinitshahdeo

@vinitshahdeo My PR has merged to branch feature/backend-node. Is there any additional step I have to take? I think I completely solve this issue

huonggiangbui avatar Mar 06 '20 09:03 huonggiangbui

Because file api/server.js doesnt place in branch master so I think I shouldnt merge to that branch?

huonggiangbui avatar Mar 06 '20 09:03 huonggiangbui

Nope, it's done from your end. I will merge feature/backend-node into master and this will close the issue.

vinitshahdeo avatar Mar 06 '20 09:03 vinitshahdeo

hi i am interested in working open source .would you please assign me too

ahmedshakill avatar Mar 10 '20 17:03 ahmedshakill

Hi. I have never contributed to open source before. Can you assign this to me? @vinitshahdeo

SomyaGandhi avatar Mar 10 '20 17:03 SomyaGandhi

Can you tell me in brief what to do in admin dashboard..and what login process you want ? Pleas tell me ellaborately

On Tue, 10 Mar 2020, 22:32 kingpin, [email protected] wrote:

hi i am interested in working open source .would you please assign me too

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vinitshahdeo/Water-Monitoring-System/issues/46?email_source=notifications&email_token=AMTHD4CA3LTVHN3KNSLMOZTRGZXDLA5CNFSM4K6UE5VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOMI2IQ#issuecomment-597200162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMTHD4FOHIXXZEPYZADKOF3RGZXDLANCNFSM4K6UE5VA .

ayan-biswas0412 avatar Mar 10 '20 17:03 ayan-biswas0412

@vinitshahdeo Pl give any task!

kichloo avatar Mar 17 '20 08:03 kichloo

I cant see the server.js file in the codebase

EZENGESH avatar Feb 13 '24 08:02 EZENGESH