Water-Monitoring-System icon indicating copy to clipboard operation
Water-Monitoring-System copied to clipboard

Published 20 hours ago • verified publisher icon vinitshahdeo

Replace the inline and internal CSS with Bootstrap classes

Open amaaniqbal opened this issue 4 years ago • 16 comments

Describe the bug Currently, custom CSS was applied to different HTML elements on the webpage even though the corresponding Bootstrap 4 class exists for them. This creates a silly overhead and increases the complexity of the code.

Expected behavior Remove all the custom CSS maybe except for the one applied to the body tag and add corresponding Bootstrap 4 classes.

Additional context Please note that to fix this, issue #118 needs to be worked upon first.

amaaniqbal avatar Mar 05 '20 14:03 amaaniqbal

I can do this ... Assign me this task

vngarg avatar Mar 05 '20 14:03 vngarg

I would like to work on this issue. I haven't been assigned any issue yet.

ashishnagpal2498 avatar Mar 05 '20 16:03 ashishnagpal2498

I can do this

Sbabureddy avatar Mar 05 '20 18:03 Sbabureddy

can I take this issue?

huonggiangbui avatar Mar 05 '20 19:03 huonggiangbui

I would love to work on this issue, would be grateful if you assigned me this issue. Thanku!

ayushi0014 avatar Mar 06 '20 08:03 ayushi0014

Can i take up this issue?

manan-bedi2908 avatar Mar 06 '20 13:03 manan-bedi2908

May I work on this issue?

goyalmuskan avatar Mar 07 '20 07:03 goyalmuskan

can i take up the issue if not previously assigned to anyone?

srishtiBajpai avatar Mar 07 '20 09:03 srishtiBajpai

Hi @ashishnagpal2498, you may take up this issue and try to complete it asap.

PragatiVerma18 avatar Mar 07 '20 13:03 PragatiVerma18

Okay , working on it.

ashishnagpal2498 avatar Mar 07 '20 13:03 ashishnagpal2498

Hi, is this issue still unresolved? If yes, I would love to work upon it. Thanks!

ShauryaBhandari avatar Mar 09 '20 15:03 ShauryaBhandari

if anybody not working on this i would like to try for it

daya2940 avatar Mar 14 '20 06:03 daya2940

Hi can you please assign this to me ?

Sagarika00 avatar May 17 '20 04:05 Sagarika00

@daya2940 go ahead and work on this issue.

PragatiVerma18 avatar May 18 '20 18:05 PragatiVerma18

Ok i am on it

On Mon, 18 May, 2020, 11:43 PM Pragati Verma, [email protected] wrote:

@daya2940 https://github.com/daya2940 go ahead and work on this issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vinitshahdeo/Water-Monitoring-System/issues/122#issuecomment-630351706, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH4UJ5KCRL3GB7JHUXWL6LDRSF3GFANCNFSM4LCLFE3Q .

daya2940 avatar May 18 '20 18:05 daya2940

Hi @PragatiVerma18 , I have already given a PR for this issue. Kindly look into it #182 .

ashishnagpal2498 avatar May 18 '20 19:05 ashishnagpal2498