PortScanner icon indicating copy to clipboard operation
PortScanner copied to clipboard

Feature/python3.8

Open avinashkranjan opened this issue 4 years ago • 7 comments

Description

fixes issue 57 updating code from python2.7 to python3

Fixes #57

Type of change

Added ip scanner

  • [❌ ] Bug fix (non-breaking change which fixes an issue)
  • [✔ ] New feature (non-breaking change which adds functionality)
  • [❌ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

Checklist:

  • [✔ ] My code follows the style guidelines of this project
  • [ ✔] I have performed a self-review of my own code
  • [✔ ] I have commented my code, particularly in hard-to-understand areas
  • [❌ ] I have made corresponding changes to the documentation
  • [✔ ] My changes generate no new warnings
  • [✔ ] I have added tests that prove my fix is effective or that my feature works
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have added all the three reviewers: @vinitshahdeo, @kashish121 & @ishika1727

avinashkranjan avatar Aug 21 '20 07:08 avinashkranjan

@vinitshahdeo @Kashish121 @ishika1727 Please review the changes

avinashkranjan avatar Aug 21 '20 15:08 avinashkranjan

@vinitshahdeo Resolved..Hav a look.

avinashkranjan avatar Aug 26 '20 09:08 avinashkranjan

@Kashish121 @ishika1727 If you guys could have a look too..

avinashkranjan avatar Aug 26 '20 09:08 avinashkranjan

Left comments.

What? I didn't get that..

avinashkranjan avatar Aug 27 '20 11:08 avinashkranjan

@vinitshahdeo Any Updates

avinashkranjan avatar Sep 02 '20 08:09 avinashkranjan

@vinitshahdeo any updates?

avinashkranjan avatar Sep 13 '20 15:09 avinashkranjan

@vinitshahdeo When will it get merged

avinashkranjan avatar Sep 25 '20 07:09 avinashkranjan