PortScanner icon indicating copy to clipboard operation
PortScanner copied to clipboard

Rectified nav-items' position

Open deprov447 opened this issue 4 years ago • 6 comments

Description

Centered the position of Navbar Items in SideNav in index.html

Fixes #56

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [x] I have added all the three reviewers: @vinitshahdeo, @kashish121 & @ishika1727

deprov447 avatar Aug 17 '20 05:08 deprov447

@Kashish121 @vinitshahdeo @ishika1727 Please review this PR

deprov447 avatar Aug 17 '20 05:08 deprov447

@deprov447 can you please also add the screenshot of the final output?

Kashish121 avatar Aug 17 '20 09:08 Kashish121

@Kashish121 Screenshots in 2 different viewport sizes: port port2

deprov447 avatar Aug 17 '20 14:08 deprov447

@vinitshahdeo I have merged the commit in this PR only issue #70

deprov447 avatar Aug 17 '20 16:08 deprov447

@ishika1727 @Kashish121 @vinitshahdeo Please review the changes.

deprov447 avatar Aug 20 '20 11:08 deprov447

@Kashish121 @ishika1727 @vinitshahdeo please review the PR

deprov447 avatar Sep 03 '20 10:09 deprov447