PortScanner
PortScanner copied to clipboard
vinitshahdeo
[BUG] [Frontend] Adjust the Timer Size
The size of the timer/clock should vary according to the screen size. In mobile view, the timer should appear below the input fields and the button.
@Amulya-coder please go ahead 👍 Create a PR by wednesday EOD. Also, if you are participant of Hakincodes please introduce yourself in the Welcome to Hakincodes thread. 👋 It will help us keep track of your progress and contributions during the period. 😄
@ishika1727 Can you tell me a little more about what timer you should indicate the red or blue and what you mean by adjust the Timer size its look fine in 217px Can you through some light on this so that I can understand.
@Amulya-coder you have to reduce the size of the time shown on the right hand side(time taken to fetch the results). Refer the README.md for steps to run the application and reduce the timer size i.e. the seconds and minutes shown
@Amulya-coder you have to reduce the size of the time shown on the right hand side(time taken to fetch the results). Refer the
README.mdfor steps to run the application and reduce the timer size i.e. the seconds and minutes shown
@ishika1727 thank you for your quick response I got it . I read the README.md and follows each and every steps and install all the dependencies but there is another problem came when I run the python src/scanner.py command in my terminal it will show some error I think something have not done correctly I will also attach the screenshot of this below. Can you please help me out for fixing this.
@ishika1727 can you help me out for fixing this error that is shown in the terminal .
@ishika1727 the Port Scanner runs and it will shows all the open ports in the terminal but the website was not shown in a correct manner when I open in the browser it will displayed like this why?
@Amulya-coder I can see you are directly walking into src/templates/index.html.
Follow these steps here to run the program locally and enter the url which the program returns (step 6).
@Amulya-coder please refer to feature/frontend branch rather than the master branch and make changes in that only.
@Kashish121 I follow these steps as you mentioned it will running and returned the URL but when I click on the URL it opens the website in this way
@Amulya-coder give the following inputs and then start scanning with the scan now button. The timer will be displayed.
Host to scan: localhost low: 1 high: 20
@ishika1727 still not shows the timer it will show range and below it time
@ishika1727 why it is not showing in the way like that it shows in your's.
@Amulya-coder please don't run src/templates/index.html directly.
Follow these steps here to run the program locally and then make the changes in frontend files.
The backend and frontend are connected using flask in the mainscanner.py that is why directly running it it giving different result.
@Amulya-coder that's because this screen shot is out dated. We have merged new changes few hours ago, I suggest you clone the repository again and try running. Also, the timer will appear only during the scanning process. Not before and after.
@ishika1727 why it is not showing in the way like that it shows in your's.
@ishika1727 In timer size I have seen directly that it's size is bigger because of not proper font sizing so to adjust it I have to particularly find that file and then make changes in it so what's your suggestions.
@vinitshahdeo @Kashish121 I have made the PR .Can you please verify and merge it.
@vinitshahdeo I have made the required changes please review it . Thanks.
Timer Adjusted #100