PortScanner icon indicating copy to clipboard operation
PortScanner copied to clipboard

[Feature] Include ipscanner feature in python3 .

Open Kashish121 opened this issue 3 years ago • 5 comments

The master branch of the repository is maintained for python2 whereas the feature/python3.8 branch is maintained for python3.

The 'ipscanner' feature in master ( src/ipscanner.py ) is compatible with python2, write the corresponding python3 code for 'ipscanner' and create a PR in feature/python3.8 branch.

Kashish121 avatar Aug 16 '20 17:08 Kashish121

I'd like to work on this issue..

avinashkranjan avatar Aug 16 '20 19:08 avinashkranjan

Yes @avinashkranjan , please go ahead. 👍

Kashish121 avatar Aug 16 '20 19:08 Kashish121

Also, @avinashkranjan if you are a participant of Hakincodes please introduce yourselves in the Welcome to Hakincodes thread. 👋 It will help us keep track of your progress and contributions during the period. 😄

Ignore if already done.

Kashish121 avatar Aug 16 '20 19:08 Kashish121

I making changes listed below:

  • Updating config.json in root of feature/python3.8
  • Adding multi directory for the files init.py & scanner_thread.py
  • Adding ipscanner.py which was main issue.

Pushing changes in feature/python3.8 have a look

avinashkranjan avatar Aug 21 '20 07:08 avinashkranjan

@Kashish121 I have created a PR for the same if you could have a look here

avinashkranjan avatar Oct 03 '20 19:10 avinashkranjan