MiniYouTube icon indicating copy to clipboard operation
MiniYouTube copied to clipboard

Add ESLint

Open vinitshahdeo opened this issue 5 years ago • 11 comments

Linting is the process of checking the source code for Programmatic as well as Stylistic errors.

Adding ESLint will be helpful in identifying some common and uncommon mistakes that are made during coding.

ESLint covers both code quality and coding style issues.

  • Add ESLint to this project.
  • Add scripts in package.json i.e. npm run test-lint should run lint tests.
  • Do not make any changes to other files.

Please refer this.

vinitshahdeo avatar Oct 10 '19 14:10 vinitshahdeo

I'll do this

grigori-gru avatar Oct 10 '19 14:10 grigori-gru

@grigori-gru Yes, please!

vinitshahdeo avatar Oct 10 '19 14:10 vinitshahdeo

I do this but my access is denied

aleoof avatar Oct 10 '19 14:10 aleoof

is this issue open?

kalpananegi avatar Oct 15 '19 05:10 kalpananegi

@kalpananegi Yes, give it a shot or you may look into a few good first issues which are up for grabs.

:white_check_mark: Link to the repository

vinitshahdeo avatar Oct 15 '19 06:10 vinitshahdeo

is this issue still open? I would like to do this.

kushal-khare-official avatar Oct 02 '20 06:10 kushal-khare-official

@vinitshahdeo I have a branch ready but I need permission to create a branch and open the PR

arielhad avatar Oct 13 '20 23:10 arielhad

@aleoof @arielhad You have to create a fork of this repository, make the commits on your fork, push them up, and then create a pull request.

You will not have permission issues anymore because you are the maintainer of the fork.

Here is an article with more information: https://opensource.com/article/19/7/create-pull-request-github

mvpowers avatar Oct 24 '20 16:10 mvpowers

@vinitshahdeo @mvpowers Can you please review my PR: https://github.com/vinitshahdeo/MiniYouTube/pull/27

arielhad avatar Oct 24 '20 19:10 arielhad

Can I work upon this issue under hacktoberfest @vinitshahdeo

Akshit42-hue avatar Oct 01 '21 03:10 Akshit42-hue

I have added the ESLint .please review my PR @vinitshahdeo

tanwi1234 avatar Oct 02 '21 15:10 tanwi1234