Vinita Murthi

Results 11 comments of Vinita Murthi

Today yes, but as we had discussed we will move this to its own module in blaze so this confusion should be short lived. Unfortunately with the way its structured...

I think that's right. I beleive all other logging should be part of oppialogger now so we should just have to update callers.

> @vinitamurthi there is a issue with enum `PolicyPage`. I am getting error as unreferenced `PolicyPage` in ci tests, where as in Android studio it is not giving any error....

Sure you can work on this. The Android Studio lint command works for every file right? I am worried that lint would end up affecting our kotlin/protobuf files as well

Another thing to keep in mind is that we need to run the linter on circleCI as well, which will not have android studio installed. Also avoid using gradle linting...

> > Sure you can work on this. The Android Studio lint command works for every file right? I am worried that lint would end up affecting our kotlin/protobuf files...

It would be a good idea to write this down into a small design doc, and we can review it before going forward!

@NullByte08 Any update on this issue?

Sounds good, if we can run it on CircleCI then I am totally open to using this. As far as the style guide goes, we have a guide written down...

If you mean #1742 be blocked on this issue then yes I think it should be