flask-apscheduler icon indicating copy to clipboard operation
flask-apscheduler copied to clipboard

Add endpoints to modify the scheduler state

Open viniciuschiele opened this issue 4 years ago • 1 comments

  • Add endpoints to modify the scheduler state
  • Requested on #179

viniciuschiele avatar Aug 14 '21 11:08 viniciuschiele

Looks good. Could you also make the wait option available? being able to tell wait=False when shutting down the scheduler would be helpful in my use cases.

https://apscheduler.readthedocs.io/en/stable/userguide.html#shutting-down-the-scheduler

Thanks

mxdev88 avatar Aug 22 '21 15:08 mxdev88

@mxdev88 I added in a option to use post json to force a shutown.

client.post(self.scheduler.api_prefix + '/shutdown', json={'wait':'False'})

christopherpickering avatar Mar 20 '23 20:03 christopherpickering

Codecov Report

Patch coverage: 77.14% and project coverage change: -1.25 :warning:

Comparison is base (bab402b) 92.92% compared to head (a303580) 91.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   92.92%   91.68%   -1.25%     
==========================================
  Files           6        6              
  Lines         410      445      +35     
==========================================
+ Hits          381      408      +27     
- Misses         29       37       +8     
Impacted Files Coverage Δ
flask_apscheduler/api.py 83.05% <74.19%> (-3.16%) :arrow_down:
flask_apscheduler/scheduler.py 99.41% <100.00%> (+0.01%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Mar 21 '23 12:03 codecov[bot]

@viniciuschiele we can fix the codecov fail on another pr maybe?

christopherpickering avatar Mar 23 '23 13:03 christopherpickering

Yes, I've created this issue #223

viniciuschiele avatar Mar 23 '23 13:03 viniciuschiele