Robin Weinreich

Results 29 comments of Robin Weinreich

I can say that the issue discussed here is somehow related to the saving of the patch. In `mongoose` there are 2 options (probably) to save a new document. Either...

### Summary The timeout error origins in an undefined mongoose connection for our `mongoose-patch-history` plugin. *Quick workaround:* Change `Mongoose.createConnection()` to `Mongoose.connect()` in `lib/index.js`. This uses the default mongoose connection instead...

Hey there @danielbayerlein, I created some types for my own use. `mongoose-patch-history.d.ts` ```ts declare module "mongoose-patch-history" { import mongoose = require("mongoose"); export default function (schema: mongoose.Schema, opts: { mongoose: mongoose.Mongoose;...

Thanks for you input! Looks good. If I might ask for you opinion: - Further enhance the types to support access on `patches` for each `mongoose.document` - Use this as...

Hey @jamesholcomb, thanks for letting us know! I think we can support this. I'll have a deeper look over the weekend.

Hey @jamesholcomb i know some time has passed by I finally made the time to dig through all open issues. Hopefully you still somewhat know what this was about. In...

Thanks for answering! Then I would propose throwing an error and providing a config option to disable error throwing?

Under `plugin hooks` i understand the functionality of the plugin. So if the`lean` or `rawResult` option is detected we can disable the plugin functionality (configurable). So either throw error or...

> But it's hard to predict every use case, so I understand the point of view. Isn't `lean` basically circumventing mongoose? It is used to gather raw results, it can...

Just for reference I believe this feature is supported by the usage of `virtuals` and the `includes` option as specified in the [README](https://github.com/codepunkt/mongoose-patch-history#includes). Edit: typo