Vincent Koc

Results 58 comments of Vincent Koc

@michaelcabiareyes Hey, I'm one of the Airbyte maintainers and I'll be taking a look at your PR. Firstly thanks for your contribution :) The code logic seems sounds but the...

@michaelcabiareyes ill need to run the unit tests using github actions. Its not able to be triggered by public.

/test connector=connectors/source-okta > :clock2: connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/3978035263 > :x: connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/3978035263 > :bug: https://gradle.com/s/v6dxvkjhfo3va > ### Build Failed Test summary info: ``` =========================== short test summary info ============================ FAILED unit_tests/test_streams.py::TestStreamGroupMembers::test_group_members_request_params_with_latest_entry ==================...

@michaelcabiareyes fyi test is still failing. You can follow the steps in the connector readme to use gradle commands to test locally the acceptance tests before you make your changes...

/test connector=connectors/source-okta > :clock2: connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/3982519582 > :x: connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/3982519582 > :bug: https://gradle.com/s/q4xnw4ph2c4jg > ### Build Failed Test summary info: ``` =========================== short test summary info ============================ FAILED test_core.py::TestBasicRead::test_read[inputs0] -...

@natalyjazzviolin can you give any guidance on the unit testing side of things?

/test connector=connectors/source-okta > :clock2: connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/4039183208 > :x: connectors/source-okta https://github.com/airbytehq/airbyte/actions/runs/4039183208 > :bug: https://gradle.com/s/t5f6tbtnvjjcy > ### Build Failed Test summary info: ``` =========================== short test summary info ============================ FAILED test_core.py::TestBasicRead::test_read[inputs0] -...

@korobochkin have a look at my repo: https://github.com/koconder/wordpress-test-template and a plugin you can see the Travis CI setup on: https://github.com/koconder/wordpress-test-template Shout if you need me to jump in and build...