Vincent

Results 85 comments of Vincent

@Spomky Question regarding the configuration of this feature: why adding `user_provider` option, and not rely on the firewall _user provider_?

Hi @Shre1892YNWA, can you provide a reproducer please?

In progress here => https://github.com/lexik/LexikJWTAuthenticationBundle/pull/1098 /cc @chalasr

To reduce the code complexity and improve the code architecture, I highly recommend to build a `Provider` object in `CoopTilleulsForgotPasswordExtension::load`. This new object can be injected anywhere to access provider...

Hi @aziz-harazi, Thanks for the ping. I'm reviewing it asap. Watch out as 2 comments has not been fixed IMHO: https://github.com/coopTilleuls/CoopTilleulsForgotPasswordBundle/pull/107#discussion_r1087870681 and https://github.com/coopTilleuls/CoopTilleulsForgotPasswordBundle/pull/107#discussion_r1087883274.

Hi @aziz-harazi, friendly reminder to don't forget about those comments: - https://github.com/coopTilleuls/CoopTilleulsForgotPasswordBundle/pull/107#discussion_r1116113162 - https://github.com/coopTilleuls/CoopTilleulsForgotPasswordBundle/pull/107#discussion_r1116118151 - https://github.com/coopTilleuls/CoopTilleulsForgotPasswordBundle/pull/107#discussion_r1117163976

Hi @aziz-harazi, I don't see your answers to these comments. The 2 remaining points are: - the `$manager` must come from the provider (in PasswordTokenManager and ForgotPasswordManager) - add some...

> I did not take into account. I supposed that it works only with doctrine as long as super class CoopTilleuls\ForgotPasswordBundle\Entity\AbstractPasswordToken is mapped with doctrine The bundle provides a default...

Hi @aziz-harazi, Do you need some help for integrating the manager in the provider? (https://github.com/coopTilleuls/CoopTilleulsForgotPasswordBundle/pull/107#discussion_r1116113162 and https://github.com/coopTilleuls/CoopTilleulsForgotPasswordBundle/pull/107#discussion_r1116118151) If you want, I can commit on your branch to fix this last...

@azizharazi don't hesitate to check my last commits :wink: I approved this PR, and asked another dev to have a look just in case! You have done a huge work!!!...