project-clippi icon indicating copy to clipboard operation
project-clippi copied to clipboard

Ability to choose replay files to find highlights in

Open jazzdan opened this issue 4 years ago • 1 comments

Maybe I have a weird setup, but it seems useful to me to be able to select just some replay files to process rather than having to process the whole directory.

My setup is:

  1. Slippi is set to put replays in C:\Users\me\Documents\Slippi
  2. I never want to delete a replay because I'm totally going to look through all of these replays and take notes to get better. Even though uhh I haven't done that yet.

So when I run project clippi in C:\Users\me\Documents\Slippi it always runs over all of my replays, which takes a while, and I end up with a bunch of combos I have already seen so the "Load output file into Dolphin when complete" option isn't very useful.

It would be better for me if I could manually select which replay files to process or if I could specify a time range like "only look at files modified in the last week".

Thanks for the great project! If this sounds amenable to folks I can try to put a PR together too.

jazzdan avatar Jul 03 '20 15:07 jazzdan

I think to achieve what you're proposing it's not too hard for someone to simply create a new temp folder say .../Documents/Slippi/tmp and just put some SLP files in there, and change the SLP directory to that folder. I know it's not very clean, but I think it's simple and it works.

Allowing users to manually add files or select time frames etc would be cool and would help power users, I think it could overly complicate the process for not-so-savvy users. But if you think you can add the functionality while keeping the UI/UX clean and without overbearing new users I'd definitely be happy to review a PR for it.

vinceau avatar Jul 04 '20 00:07 vinceau