Vinay Gaba

Results 107 comments of Vinay Gaba

@elihart I think Varun is running a test with these changes.

@oas004 We are on a newer version of Kotlin now. Maybe we can revisit this? Hopefully that will help simplify our code a bit and we won't need to fork...

> Do you know if the plan is to continue support for KAPT with Showkase long term @oas004 Good question. I thought about this a bit and I see a...

@oas004 Interesting. Yes the version of xprocessing was upgraded, although it's not the latest version. Was done in this PR - https://github.com/airbnb/Showkase/commit/360259e07d86a28548a2795c2d2d66ffe4f5e80a

@JeremiahStephenson Is this only happening in the multi preview context? i.e can you confirm you aren't seeing this when you are not using multi-preview?

This has been fixed with the following change - https://github.com/airbnb/Showkase/pull/383

I was looking into it just yesterday. I think this should be possible to do if I do some minor refactors. Also related to #115

@narayan07feb @sjaramillo10 I suspect this might be because internet permission isn't added to the `ShowkaseBrowserActivity` manifest by the library. However, you can solve this on your end by making sure...

@sjaramillo10 Can you fork this repo and swap out the picasso dependencies from the sample module to Coil - https://github.com/airbnb/Showkase/blob/master/sample/build.gradle#L113 If there's issue with the library, it should be a...

@narayan07feb @sjaramillo10 I was able to investigate and I think I know what's going on - Showkase ensures that it conveys that it's a preview environment here (Correct/Intended behavior) -...