Vinay Gaba

Results 107 comments of Vinay Gaba

I think that's a Compose requirement itself. I haven't double checked this but that's what I always assumed.

@alexvanyo Very cool! I had initially taken the parameterized test route myself but eventually found a limitation that didn't allow us to use it with our setup. It was something...

@alexvanyo No I meant for the original implementation of automated screenshot testing itself. It wasn't using Paparazzi then but I think this might be viable now that Paparazzi supports Compose.

Just as an update to an earlier comment on this thread, I did push a PR that adds Shot integration as a new artifact - https://github.com/airbnb/Showkase/pull/232. This should give you...

@themanol I've somehow missed seeing this PR. Truly apologize for that. I'm ready to merge it once the builds pass.

@ReginFell I was able to repro and have a fix pushed for it

I do think that since @Preview supports this, we should support it as well. Unsure about the technical feasibility as I'll have to play with it before I can jump...

@iamutkarshtiwari This has been implemented in this PR - https://github.com/airbnb/Showkase/commit/3dffbac3a955804a21357fbb26f9443f040a1650 Closing this issue.

Are you using a release build of the Showkase browser? The primary use case of the app was in the debug mode so an R8 rule wasn't exported with the...

We actually have a test to verify exactly this - https://github.com/airbnb/Showkase/blob/0106b8bfa60b6a0bac32840a00d1fa67c6045f38/showkase-browser-testing/src/main/java/com/airbnb/android/showkase_browser_testing/TestComposables.kt#L14 Not sure if you were doing something different 🤔