Vinay Gaba

Results 107 comments of Vinay Gaba

Leaving it open to gauge interest.

This might not be necessary given the limited Bitmap creations as part of the library. Although, it would be efficient for someone using the library multiple times in the same...

Hey @GainLee! Thank you for stopping by. I will certainly look into this!

@dturner We've started the work to have multi-preview support in Showkase (which was the missing piece). Is that the crash you were referring to?

@alexvanyo Yes, it's being worked on. This is the second PR with the goal to have full multi preview support - https://github.com/airbnb/Showkase/pull/259/ The previous PR ensured that there are no...

@marcorighini I'm not a fan of adding so many one off properties to `@ShowkaseComposable`. It's not elegant - moreover, Showkase exposes all your previews that it collects through the `Showkase.getMetadata()`...

Thanks for flagging this! I think I should be able to skip this check when its applied to an annotation class. I believe I should have this information available and...

@alexvanyo Actually @oas004 has already implemented and merged stacking previews functionally in this PR - https://github.com/airbnb/Showkase/pull/259 So we are very close to having proper multi preview support (final PR here...

@elihart @pmecho I'd love to get y'all to chime in as well. What according to y'all should be the ideal behavior?

Showkase itself doesn't provide any integrations (yet). The blog post that you probably saw(https://proandroiddev.com/automatic-screenshot-testing-for-all-your-compose-previews-6add202fecc7) used Showkase for the automated infra but then integrated it with Facebook's library. In theory, it...