Vinay Gaba

Results 107 comments of Vinay Gaba

@jd565 @iamutkarshtiwari In theory, your project can have multiple `ShowkaseRoot` implementations and that's supported already. This allows you to also have multiple screenshot tests, each focused on a different tree...

@jd565 Started implementing some functionality that will address this. Take a look if you have thoughts and would like to shape the API - https://github.com/airbnb/Showkase/pull/392

Yeah I think this will help make the library be more deterministic. Especially the APIs that are generated at the top level should probably be generated to make sure there...

Thanks, I do see the problem and I don't think it's intended to be like this. I think having a single artifact makes sense to me. I can fix this...

@popovanton0 also, thank you for the write up and documenting a way to unblock people until the fix is merged

Published a PR to fix this - https://github.com/airbnb/Showkase/pull/291 Not 100% sure I have the right fix so if either of you have thoughts, please chime in on the PR @kibotu...

@evant Seeing a bunch of test errors. Might need more investigation

Closing in favor of this [PR](https://github.com/airbnb/Showkase/pull/384) that already merged and took care of it. Really appreciate your contribution thought 🙏

This is a reasonable request!

Seems like a lot of people have encountered this. I'll prioritize this work and make Showkase compatible with Kotlin 1.9