conrad icon indicating copy to clipboard operation
conrad copied to clipboard

[MRG] Add feature #6 conrad reset

Open JosemyDuarte opened this issue 5 years ago • 3 comments

Please let me know if you are Ok with the messages.

I was thinking of putting conrad_db_path and conrad_events_path in __init__.py since I saw that we made use of that concatenation in many places and I think it would be a good idea to have it centralized in one place and remove the code duplication. What do you think? I didn't address that in this PR because I thought it would be better to address it in a different issue/PR. If you agree I can work on that too.

JosemyDuarte avatar Nov 01 '19 08:11 JosemyDuarte

I was thinking of putting conrad_db_path and conrad_events_path in init.py since I saw that we made use of that concatenation in many places and I think it would be a good idea to have it centralized in one place and remove the code duplication. What do you think?

I think that's a great idea!

vinayak-mehta avatar Nov 05 '19 18:11 vinayak-mehta

I'm rethinking this, it's like everything is being removed. It's like an uninstall, so reset might not be a good verb to use here.

vinayak-mehta avatar Nov 05 '19 19:11 vinayak-mehta

You are ok with the logic, but you want to change the command name, right? Or is the other way around?

JosemyDuarte avatar Nov 06 '19 11:11 JosemyDuarte