action-zip icon indicating copy to clipboard operation
action-zip copied to clipboard

Folders are not included directly

Open kvark opened this issue 4 years ago • 5 comments

Looks like the contents of the folders are included instead of the folders themselves. https://github.com/kvark/vange-rs/runs/3389417025?check_suite_focus=true

Run papeloto/action-zip@v1
  with:
    files: res config road model car level convert
    dest: vangers-macos-latest.zip
    recursive: true
Ready to zip "res config road model car level convert" into vangers-macos-latest.zip
  - res
  - config
  - road
  - model
  - car
  - level
  - convert

Zipped file vangers-macos-latest.zip successfully

Downloading the file and unzipping it shows me:

graphics35334:vangers-macos-latest dmalyshau$ ls -l
total 60632
-rw-rw-r--@  1 dmalyshau  staff  7109656 21 Aug  2021 car
-rw-rw-r--@  1 dmalyshau  staff  1751632 21 Aug  2021 convert
-rw-rw-r--@  1 dmalyshau  staff  7396816 21 Aug  2021 level
-rw-rw-r--@  1 dmalyshau  staff  7016240 21 Aug  2021 model
-rw-rw-r--@  1 dmalyshau  staff  7759656 21 Aug  2021 road
-rw-rw-r--@  1 dmalyshau  staff     1571 21 Aug  2021 settings.template.ron
drwxrwxr-x@ 20 dmalyshau  staff      640 21 Aug  2021 shader

So, instead of res folder, the archive contains the shader folder, which is inside. Same for config, which is absent, but the file from it is here.

kvark avatar Aug 21 '21 14:08 kvark

i have the same issue, the listed directory is not included in the zip only it's content is part of the zip

bahag-welscha avatar Aug 25 '21 14:08 bahag-welscha

This is actually good for me, I wanted my build to be listed as a release and I was worried it would have the folder structure.

Unity123 avatar Aug 27 '21 16:08 Unity123

I think the docs about the recursive option is misleading as example works exactly opposite to docs. Settings recursive: false will put folders in archive as is

meskill avatar Sep 12 '21 15:09 meskill

I think the docs about the recursive option is misleading as example works exactly opposite to docs. Settings recursive: false will put folders in archive as is

You are right! The behavior is exactly the opposite.

epassaro avatar Jan 28 '23 22:01 epassaro

Created this PR to fix the issue: https://github.com/vimtor/action-zip/pull/23

Better to change the docs than the code so if someone has it working the change won't affect their action.

julillosamaral avatar Feb 07 '23 13:02 julillosamaral