action-zip
action-zip copied to clipboard
Suggest a strategy to include absolute paths
If I understand correctly, the current implementation treats all paths as relative to GITHUB_WORKSPACE. It would be great if we could have a strategy to support absolute paths, e.g. by:
- introducing a default-true "relative" property
- suggesting a way to change GITHUB_WORKSPACE to the empty string
I second this. At first I tried setting working-directory
, which didn't work (Unexpected value 'working-directory'
). Then I tried giving all paths as absolute paths, which failed on Linux/OSX with (Not Found)
(yet reported success and created an empty zip!) and on Windows with ENOENT: no such file or directory
(this time properly reporting the failure). Then finally stumbled on this issue, which gave me the solution.
I think supporting working-directory
would be the way to go.
+1
I also avoid working with relative paths as much as possible. Allowing the user to control the input/output paths explicitly with absolute paths not only affords the most flexibility but also the most clarity around what this action is doing.