vimperator-labs icon indicating copy to clipboard operation
vimperator-labs copied to clipboard

No link hints in Google, when statusline is toggled off

Open c0ffeeartc opened this issue 9 years ago • 14 comments

Vimperator version 3.11.3. Firefox/44.0

Steps to reproduce:

// Hide statusline and open google.com
:js statusline.setVisibility(statusline.setVisibility.TOGGLE)<CR>
:open google.com<CR>

hit 'f' to show hints Result: no hints and message in statusline:

InvalidStateError : An attempt was made to use an object that is not, or is no longer, usable

c0ffeeartc avatar Feb 09 '16 10:02 c0ffeeartc

Huh, that's weird but yeah, I see it too.

gkatsev avatar Feb 13 '16 20:02 gkatsev

I'm seeing this also, so I don't see hints in fullscreen mode.

bzub avatar Mar 04 '16 01:03 bzub

Same problem here

riotbit avatar Mar 24 '16 04:03 riotbit

Same problem with FF 45

aminroosta avatar Apr 09 '16 16:04 aminroosta

After I updated OS X to El Capitan, same problem has happened with Firefox 45.0.1 and Vimp 3.12.0 .

Nnwww avatar Apr 13 '16 08:04 Nnwww

Having same issue on OSX El Capitan

chergik avatar Apr 23 '16 01:04 chergik

I can reproduce this error with Firefox 46.0, Viperator 3.13.1

A red line pops up briefly before being replaced by the search prompt.

It says: "InvalidState error: An attempt was made to use an object that is not, or is no longer, usable."

Edit: I missed that this has already been mentioned. Just confirming this for FF46 then. Edit2: can confirm with youtube.com, too.

thegoodhen avatar May 09 '16 09:05 thegoodhen

I have the same issue. When i'm gone fullscreen, there's no hint shown on any links on page. (i've noticed it on google.com only)

firefox 46.0.1 vimperator 3.13.0

bibek22 avatar May 15 '16 12:05 bibek22

QuickHint mode finds no links on google.com, but it works on baidu.com the first time (then you need to make a force reload) for me. After I switch to the default theme, this problem is gone.

I'm using the vimperator-theme-fxdevtools-dark theme, After I made some custom modification, and QuickHint works for me too! https://github.com/danemacmillan/vimperator-theme-fxdevtools-dark

-highlight PromptText background: #1D4F73; border-top: 2px solid #d7f1ff; border-bottom: 2px solid #173F5C; padding: 3px 5px 0 5px; color: #EDF0F1;
+highlight PromptText background: #1D4F73; border-top-style: solid; border-top-color: #d7f1ff; border-bottom-style:solid; border-bottom-color: #173F5C; padding-left: 5px; padding-right: 5px;
 highlight Question color: #b58900;  background: #002b36;  font-size: 12px;
-highlight StatusLine color: #F5F7FA; font-size: 12px; padding: 5px;font-family: Arial,sans-serif;
+highlight StatusLine color: #F5F7FA;

amzyang avatar Sep 27 '16 09:09 amzyang

Same with fullscreen mode on startpage.com (which allegedly is “powered by Google”—not sure what it means exactly though).

Firefox 45.4.0 Vimperator 3.14.0

akater avatar Sep 27 '16 11:09 akater

@timss Can you comment?

Looks like @sirzerator has a fix on his fork (linked above). Didn't find a PR submitted?

zaquestion avatar Sep 27 '16 20:09 zaquestion

Now I have a stacktrace.

iterateNext@chrome://liberator/content/util.js:434:64
Hints<._generate@chrome://liberator/content/hints.js:339:23
Hints<.show@chrome://liberator/content/hints.js:934:9
Hints<.mappings/<@chrome://liberator/content/hints.js:1240:27
repeat@chrome://liberator/content/mappings.js:119:27
Liberator<.trapErrors@chrome://liberator/content/liberator.js:929:20
Map<.execute@chrome://liberator/content/mappings.js:123:16
Events<.onKeyPress@chrome://liberator/content/events.js:1051:31
Events<.init/wrapListener/<@chrome://liberator/content/events.js:108:21
events/get closure/closure/<@chrome://liberator/content/base.js line 309 > eval:7:50
exception_01

amzyang avatar Sep 28 '16 02:09 amzyang

I just submitted a PR with my branch. There are so many corner cases with hinting that I didn't feel safe to submit my branch just yet, but I guess it's been laying around for long enough. Let's hope that given enough eyeballs, all bugs are shallow will apply here. Cheers !

sirzerator avatar Sep 28 '16 02:09 sirzerator

Same problem here, like @akater said

Same with fullscreen mode on startpage.com (which allegedly is “powered by Google”—not sure what it means exactly though).

Firefox-ESR 45.5.0 Vimperator 3.15.0

fenix011 avatar Dec 08 '16 18:12 fenix011