ssx icon indicating copy to clipboard operation
ssx copied to clipboard

main.go rely on internal package import

Open Alopex4 opened this issue 1 year ago • 2 comments

Hi Vimiix, As a newbie Go developer, I found the ssx/cmd/ssx/main.go relies on internal import "github.com/vimiix/ssx/internal/cleaner". In the Goland IDE it will cause an error until I modify it to "ssx/internal/cleaner".

Do you consider to move the cleaner out of internal package or give it a hook function for public involve?

If there are any mistakes or omissions in what I have mentioned, please point them out. Thank you.

Alopex4 avatar Jan 06 '24 03:01 Alopex4

@Alopex4
github.com/vimiix/ssx is module path of current project, it is defined in go.mod. If your go version is greater than v1.11, it should be indexed correctly.

Of course, we also can consider moving cleaner into the ssx module.

vimiix avatar Jan 08 '24 11:01 vimiix

I have just moved the cleaner module into the ssx module, and I will release this change in next version.

commit: https://github.com/vimiix/ssx/commit/896735b5f6c92e8dee5009a1f2e2ccdb2e7583a5

vimiix avatar Jan 08 '24 11:01 vimiix

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Jun 11 '24 02:06 github-actions[bot]