vimeo-php-lib icon indicating copy to clipboard operation
vimeo-php-lib copied to clipboard

Published 20 hours ago • verified publisher icon vimeo

Update to PSR-0

Open indytechcook opened this issue 13 years ago • 6 comments

This updates to PSR-0 compliance and adds a componser.json for http://packagist.org/ compatibility.

Review on Reviewable

indytechcook avatar Jan 17 '12 02:01 indytechcook

The suggested changes would prevent the Vimeo class to be used on php 5.2 or below since it doesn't support namespaces. I don't see why one would limit the use of the class in this way.

On an unrelated note the index.php file currently throws numerous "undefined index" notices when error reporting is set to E_ALL. Would be nice if that would be fixed. Seeing that pull request is open without any response for over 2 months and last commit on the repo was on Sep 07, 2010 I wonder if Vimeo is really committed to maintaining this repo.

ADmad avatar Mar 05 '12 13:03 ADmad

Yeah, I don't think we can use namespaces here. I'm not sure how many people use this that aren't on 5.3, but we don't want to cut them out.

bdougherty avatar Mar 07 '12 16:03 bdougherty

@bdougherty - at the very least a composer.json file would be helpful. See DailyMotions for example.

bmeynell avatar Oct 21 '12 17:10 bmeynell

+1

benedyktdryl avatar May 05 '13 16:05 benedyktdryl

+1 for adding a composer.json file

andyfleming avatar Jul 25 '13 03:07 andyfleming

Please also tag a release (with git tagging), like git tag 1.0.0. It makes it easier to download a static copy of the repo through composer.

andyfleming avatar Jul 25 '13 03:07 andyfleming