psalm icon indicating copy to clipboard operation
psalm copied to clipboard

partial revert nullable type for curl_multi_getcontent

Open kkmuffme opened this issue 2 years ago • 2 comments

Fix https://github.com/vimeo/psalm/issues/8351

Partially reverts https://github.com/vimeo/psalm/commit/f28ac7377778e281c1b406251dd839f88ea4622e

kkmuffme avatar Aug 03 '22 22:08 kkmuffme

How can the tests be fixed here? Since the reflection disagrees with the map?

kkmuffme avatar Aug 03 '22 22:08 kkmuffme

Can you put count back in ignoredFunctions with a comment explaining why? Please also add a test so we can make sure this change won't be reverted without a fix in the future

orklah avatar Aug 04 '22 05:08 orklah

@orklah I think you are talking about a different issue? (perhaps https://github.com/vimeo/psalm/issues/8346?)

No "count" here :-) ready to merge (no extra test for this, as this is a specialty case)

kkmuffme avatar Aug 16 '22 15:08 kkmuffme

It looks like curl_multi_getcontent probably needs to go in InternalCallMapHandlerTest::$ignoredFunctions to fix the failing test.

AndrolGenhald avatar Aug 16 '22 17:08 AndrolGenhald

Added it to InternalCallMapHandlerTest::$ignoredReturnTypeOnlyFunctions now. No test added, since it's in the ignored list anyway, so a test wouldn't be super useful (and a waste of my time, as this is a super niche issue)

Ready to be merged

kkmuffme avatar Sep 08 '22 19:09 kkmuffme

Thanks!

orklah avatar Sep 08 '22 20:09 orklah