psalm
psalm copied to clipboard
partial revert nullable type for curl_multi_getcontent
Fix https://github.com/vimeo/psalm/issues/8351
Partially reverts https://github.com/vimeo/psalm/commit/f28ac7377778e281c1b406251dd839f88ea4622e
How can the tests be fixed here? Since the reflection disagrees with the map?
Can you put count back in ignoredFunctions with a comment explaining why? Please also add a test so we can make sure this change won't be reverted without a fix in the future
@orklah I think you are talking about a different issue? (perhaps https://github.com/vimeo/psalm/issues/8346?)
No "count" here :-) ready to merge (no extra test for this, as this is a specialty case)
It looks like curl_multi_getcontent
probably needs to go in InternalCallMapHandlerTest::$ignoredFunctions
to fix the failing test.
Added it to InternalCallMapHandlerTest::$ignoredReturnTypeOnlyFunctions
now.
No test added, since it's in the ignored list anyway, so a test wouldn't be super useful (and a waste of my time, as this is a super niche issue)
Ready to be merged
Thanks!