Null coalescing assignment operator in if condition does not remove null from type

[M393]

https://psalm.dev/r/cdff4f688e All three functions should be without a warning as they all behave the same.

[psalm-github-bot[bot]]

I found these snippets:

https://psalm.dev/r/cdff4f688e

<?php
function f(): object|null {
    return null;
}
function a(object|null $s): object {
    if (!($s ??= f())) {
        exit;
    }
    return $s;
}
function b(object|null $s): object {
    if (!$s && !($s = f())) {
        exit;
    }
    return $s;
}
function c(object|null $s): object {
    $s ??= f();
    if (!$s) {
        exit;
    }
    return $s;
}

Psalm output (using commit 03ee02c):

ERROR: NullableReturnStatement - 9:12 - The declared return type 'object' for a is not nullable, but the function returns 'null|object'

ERROR: InvalidNullableReturnType - 5:29 - The declared return type 'object' for a is not nullable, but 'null|object' contains null

[danielbeardsley]

Ran into this as well.

Here's my attempt at a simpler example: https://psalm.dev/r/c2d540fb15

[psalm-github-bot[bot]]

I found these snippets:

https://psalm.dev/r/c2d540fb15

<?php

/** @var array<string, string> $a */
$a = [];

if ($a['missing'] ?? false) {
    echo $a['missing'];
}

if (isset($a['missing'])) {
    echo $a['missing'];
}

Psalm output (using commit cdceda0):

ERROR: RiskyTruthyFalsyComparison - 6:5 - Operand of type false|string contains type string, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead.

INFO: PossiblyUndefinedStringArrayOffset - 7:10 - Possibly undefined array offset ''missing'' is risky given expected type 'string'. Consider using isset beforehand.

[MoonE]

@danielbeardsley That's a different issue: #9098