player.js icon indicating copy to clipboard operation
player.js copied to clipboard

Remove polyfills

Open bdougherty opened this issue 1 year ago • 2 comments

We include Promise and WeakMap polyfills to the library, but both have been supported for ~10 years now. Removing both means that we can reduce the bundle size and remove all external dependencies for the production build.

Will need to think a little bit about possible implications of this changing, and of course it would need to be a major version.

bdougherty avatar Apr 02 '24 21:04 bdougherty

That would essentially drop support for IE 11: a good thing. And it seems IE 11 only needs Promise, since it supports WeakMap

BTW, this part of the code is for IE8-9 and can probably be pruned since the player does not support IE<11.

jybleau avatar Jun 27 '24 15:06 jybleau

Unfortunately I still need IE11 support 😢 When it is finally dropped, please make sure to note it in the README, ideally with a release number.

ozcoder avatar Feb 09 '25 23:02 ozcoder