player.js icon indicating copy to clipboard operation
player.js copied to clipboard

Missing "pip" and "quality" embed parameters in oEmbedParameters

Open mikeamarkey opened this issue 3 years ago • 1 comments

I'm currently planning on adding some missing Player method definitions to the @types/vimeo__player package, and when I was comparing the Embed options of the official documentation (as well as the README of this repository), I noticed that the following embed parameters are missing in oEmbedParameters:

  • pip
  • quality

Is this intentional? If not, could they be added (or could I create a PR adding them?)

Thanks! 👋

mikeamarkey avatar Apr 09 '22 01:04 mikeamarkey

As far as I know, this is not intentional. For what it's worth, they can still be used as part of the options object, just not as data attributes without being in the array. But we are happy to accept a PR!

bdougherty avatar Apr 03 '24 19:04 bdougherty