player.js icon indicating copy to clipboard operation
player.js copied to clipboard

Support Bun and Deno runtimes

Open Marcdj-02 opened this issue 1 year ago • 1 comments

Description

Per previous spec, node as a runtime (during SSR) was supported. Yet runtimes like Bun and Deno weren't. Changing the check to isServerRuntime, and adding isBun and isDeno on top of isNode will fix this.

Tests

I've tested it manually in the Bun runtime.

Marcdj-02 avatar Nov 01 '24 21:11 Marcdj-02

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 01 '24 21:11 CLAassistant

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.95%. Comparing base (00c134c) to head (9b34178). Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
+ Coverage   71.66%   71.95%   +0.28%     
==========================================
  Files           7        7              
  Lines         593      599       +6     
==========================================
+ Hits          425      431       +6     
  Misses        168      168              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 11 '25 20:07 codecov[bot]