laravel icon indicating copy to clipboard operation
laravel copied to clipboard

Laravel 6.0 support

Open azimidev opened this issue 6 years ago • 18 comments

Any chance you can make this package compatible for Laravel 6 and publish in packagist as soon as you can

azimidev avatar Sep 03 '19 16:09 azimidev

Just opened a PR on https://github.com/vimeo/laravel/pull/60

jnbn avatar Sep 04 '19 23:09 jnbn

Actually, just bumping the version is not enough. Vimeo/laravel use the package vimeo/vimeo-api that use ankitpokhrel/tus-php locked to version 0.1.0. The problem is, ankitpokhrel/tus-php 0.1.0 require Carbon 1 and not Carbon 2 that is the main requirement of laravel 6

BryanMootoosamy avatar Sep 06 '19 07:09 BryanMootoosamy

not supported yet. when support laravel6?

asterism612 avatar Sep 18 '19 05:09 asterism612

@asterism612 after the last PR it should work. Can you please define what's wrong about it?

jnbn avatar Sep 18 '19 15:09 jnbn

I still get this

vimeo/laravel 5.4.0 requires illuminate/contracts ^5.8 -> satisfiable by illuminate/contracts[v5.8.0, v5.8.11, v5.8.12, v5.8.14, v5.8.15, v5.8.17, v5.8.18, v5.8.19, v5.8.2, v5.8.20, v5.8.22, v5.8.24, v5.8.27, v5.8.28, v5.8.29, v5.8.3, v5.8.30, v5.8.31, v5.8.32, v5.8.33, v5.8.34, v5.8.35, v5.8.4, v5.8.8, v5.8.9].

azimidev avatar Sep 18 '19 19:09 azimidev

I've changed it on https://github.com/vimeo/laravel/blob/76c9cc73317bfe3c41324a9721c35dd3f4af13f9/composer.json#L19 so there should't be a problem.

jnbn avatar Sep 18 '19 19:09 jnbn

I can see that, also it's been merged, hasn't it? However, has it been tagged? Because I am using

 "vimeo/laravel": "^5.4"

in composer.json file. is that correct? if so, I still get this error!

azimidev avatar Sep 18 '19 19:09 azimidev

Oh I see.

@muglug can you please tag and release latest commits on master as 5.4.1 ?

jnbn avatar Sep 18 '19 19:09 jnbn

@hassanazimi can you try using dev-master on your composer for now?

jnbn avatar Sep 18 '19 19:09 jnbn

can't do that! composer stops working when updating! My whole app upgrade stuck because of this!

azimidev avatar Sep 18 '19 20:09 azimidev

Maybe the problem is only on 'how' it was tagged for packagist. I used ... "vimeo/laravel": "dev-master"

and works fine for me until this moment.

diegosm avatar Sep 19 '19 02:09 diegosm

Well for me when I use

"vimeo/laravel": "dev-master"

and I run composer update, composer hangs and sticks!

azimidev avatar Sep 19 '19 16:09 azimidev

I suggest deleting your composer.lock and try composer install while keeping vimeo/laravel on dev-master as it is.

jnbn avatar Sep 19 '19 18:09 jnbn

@muglug can you please tag and release latest commits on master as 5.4.1 ?

Still no support for Laravel 6.

jnbn avatar Sep 27 '19 18:09 jnbn

Same problem: - Installation request for vimeo/laravel ^5.4 -> satisfiable by vimeo/laravel[5.4.0]. - Conclusion: remove laravel/framework v6.4.1 - Conclusion: don't install laravel/framework v6.4.1 - vimeo/laravel 5.4.0 requires illuminate/support ^5.8 -> satisfiable by laravel/framework[5.8.x-dev], illuminate/support[5.8.x-dev, v5.8.0, v5.8.11, v5.8.12, v5.8.14, v5.8.15, v5.8.17, v5.8.18, v5.8.19, v5.8.2, v5.8.20, v5.8.22, v5.8.24, v5.8.27, v5.8.28, v5.8.29, v5.8.3, v5.8.30, v5.8.31, v5.8.32, v5.8.33, v5.8.34, v5.8.35, v5.8.4, v5.8.8, v5.8.9].

Is there any issue? Thanks!

mkuzmych avatar Nov 04 '19 09:11 mkuzmych

@hassanazimi hassanazimi are You found a solution of this problem?

mkuzmych avatar Nov 04 '19 09:11 mkuzmych

My fix for problem: in composer.json: "minimum-stability": "dev", "prefer-stable": true then /usr/local/bin/composer require vimeo/laravel:dev-master

mkuzmych avatar Nov 04 '19 12:11 mkuzmych

@uapixart Thanks your solution worked for me.

azimidev avatar Nov 05 '19 17:11 azimidev