vime icon indicating copy to clipboard operation
vime copied to clipboard

bug: Not running with angular 12

Open jbjhjm opened this issue 3 years ago • 2 comments

Bug Report

Vime version:

5.0.31

Current behavior:

Initialization using Angualr 12 will fail with error:

Error: Failed to execute 'define' on 'CustomElementRegistry': parameter 2 is not of type 'Function'.

Expected behavior:

Should work.

Steps to reproduce:

Minimal reproduction here: (Open the console to see error) https://stackblitz.com/edit/vime-muted-bug?file=src/app/app.component.html

jbjhjm avatar Jun 14 '21 12:06 jbjhjm

This's happening to me as well, I have a project running with angular-common ~12.1.3.

When I try to install Vime using npm npm i @vime/angular, I get the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @angular/[email protected]
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~12.1.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^11.0.4" from @vime/[email protected]
npm ERR! node_modules/@vime/angular
npm ERR!   @vime/angular@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/username/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/username/.npm/_logs/2021-08-24T12_07_38_184Z-debug.log

AmerAlahmar avatar Aug 24 '21 12:08 AmerAlahmar

@AmerAlahmar as anguar supports web components when adding CUSTOM_ELEMENTS_SCHEMA, I decided to just skip using the added overhead and complexity of the angular adapter and use the standard vime components. Suggest you to do the same, think it is the better approach.

jbjhjm avatar Aug 26 '21 12:08 jbjhjm