vim-criticmarkup icon indicating copy to clipboard operation
vim-criticmarkup copied to clipboard

Published 20 hours ago • verified publisher icon vim-pandoc

CriticMarkup not working inside some highlighting elements

Open thriveth opened this issue 10 years ago • 13 comments

Best way to illustrate the issue is by this screenshot:

Screenshot

I don't know if this is a vim-pandoc or a vim-criticmarkup issue, so I'm posting it here.

thriveth avatar Sep 12 '14 18:09 thriveth

It was a problem here. Just pushed a fix to master.

fmoralesc avatar Sep 12 '14 18:09 fmoralesc

I don't know if this is a feature or a bug, but it also does not work inside YAML blocks, like e.g. the abstract.

thriveth avatar Sep 12 '14 18:09 thriveth

I'll call that "undefined behavior"... Just pushed a fix to master.

fmoralesc avatar Sep 12 '14 19:09 fmoralesc

Feel free to tell me if it doesn't work with other stuff. I'll reopen the issue just in case.

fmoralesc avatar Sep 12 '14 19:09 fmoralesc

I just updated, and it is indeed fixed in definition lists, but still not working in YAML front matter block (specifically abstract).

thriveth avatar Sep 12 '14 20:09 thriveth

Can you tell me what is the output of

:echo synIDattr(synID(line('.'), col('.'), 1), "name")

when the cursor is in the text that needs to be highlighted?

fmoralesc avatar Sep 12 '14 20:09 fmoralesc

Yes, that is yamlPlainScalar. If I enclose it in quotes (which for other reasons is a bad idea for a multiline string in YAML), the result is yamlFlowString.

thriveth avatar Sep 12 '14 22:09 thriveth

Thanks, I pushed the required change to master.

fmoralesc avatar Sep 12 '14 22:09 fmoralesc

That seems to have broken something. It works partially, but breaks subsequent parsing of the Pandoc file: selection_004

If I remove the CM tags, it works fine:

selection_005

thriveth avatar Sep 12 '14 23:09 thriveth

I think it's an issue with the YAML syntax, with a small tweak (now in master) I have this:

captura de pantalla de 2014-09-12 21 25 22

What YAML syntax file are you using? I'm using this one

fmoralesc avatar Sep 13 '14 00:09 fmoralesc

I use whatever vim-pandoc uses. Here's what it looks like here after the latest update.

selection_006

Observation: After having inserted some more CM here, the highlight got messed up further down the pandoc MD document, but only until I ran the cursor down through the lines. This didn't happen before.

thriveth avatar Sep 13 '14 09:09 thriveth

Also: If I enclose the string in quotes, the weirdness seems to go away.

thriveth avatar Sep 13 '14 09:09 thriveth

I'm having this issue as well. Numbered lists fail when filetype=pandoc, but not when filetype=markdown. Criticmarkup shows up fine in normal text regardless of filetype.

Numbered & bulleted lists and block quotes look like this when filetype=markdown: screen shot 2015-09-22 at 12 16 56 pm

But like this when filetype=pandoc: screen shot 2015-09-22 at 12 07 04 pm

thenerdlawyer avatar Sep 22 '15 16:09 thenerdlawyer