optional-chaining-codemod icon indicating copy to clipboard operation
optional-chaining-codemod copied to clipboard

Add support for getOr

Open daveisfera opened this issue 5 years ago • 5 comments
trafficstars

Fixes #35

daveisfera avatar Sep 29 '20 04:09 daveisfera

Also, fixed the handling for of 0 in the path because it was being rejected for being falsy

daveisfera avatar Sep 29 '20 04:09 daveisfera

I added code to fix #24 as well

daveisfera avatar Sep 29 '20 14:09 daveisfera

Thanks for the PR @daveisfera ! And sorry for super late reply.

Looks like the tests are failing on this one. I've added github actions to the repo so by rebasing you'll see the results here too.

villesau avatar Oct 29 '21 08:10 villesau

I no longer have access to the codebase that I wrote this for, so I don't have a way to test/change anything with this PR. if you don't have the time/interest to fix it, then go ahead and close it.

daveisfera avatar Oct 29 '21 19:10 daveisfera

@villesau I'm gonna take a shot at getting this PR passing. Wish me luck. Thanks for making this codemod!

MasonChinkin avatar Feb 15 '22 22:02 MasonChinkin