express-http-proxy
express-http-proxy copied to clipboard
villadora
Use follow-redirects instead of default http to support redirecting
With this lib, the proxy will fully support websites that use redirects (like google.com) and still proxy the site correctly (without this the browser will redirect and stop using the proxy).
@wlepinski @marcelpanse To accept this as a patch, it would need to be an option, and off by default off. It would also need a minimal test. I like this idea, so eventually I'll pick it up if you don't.
@monkpow correct if I'm wrong but I think the follow-redirects handles this. We don't need an option.
@wlepinski No, this fork will follow redirects automatically by default, I didn't make an option for it.
@marcelpanse @wlepinski It does need an option. I understand that you're saying that the library will follow redirects automatically by default; I'm not certain that all installed users will want to switch to follow-redirects silently when they next upgrade the library. We'll need to give authors the opportunity to opt-in (rather than opting them in silently) until the next major release. If follow-redirects is popular, I'd consider making it default on a subsequent release.
Made a fork of @marcelpanse's branch to use as a git dependency from npm as well. Looking forward to when a flag is added so this can go in!
@JSchneidler yep, there actually is an update. I'm currently working on this, and expect to have a patch by end of next week.
@JSchneidler I'm continuing to work on this. I have a large scale change that I am replacing the request mechanism, and it will close this and several other large requests. It's taking a little longer than I had hoped, but I wanted to check in and let you know its proceeding, and I hope to be done in the next week or so.
Thanks for your patience.
