Viktor Strate Kløvedal

Results 177 comments of Viktor Strate Kløvedal

### Part of discussion moved to #273 The discussion has shifted towards #273 rather than being about Android Motion Photos specifically. To keep things organised, let's continue the general discussion...

Looks like it crashes if `readVideoStreamMetadata(webVideoPath)` returns a nil pointer, when it is later accessed here: https://github.com/photoview/photoview/blob/a14b12b8d49abc20e4308ceb0ba92815db671701/api/scanner/process_video.go#L108

Hmm I just looked a little closer and I can't logically trace it back to something that could cause this error. Unless you can find the video that crashes the...

I can push a special docker image that prints a debug message right before the crash. Are you running the server on amd64 or arm?

Perfect, I've pushed a amd64/x64 image to dockerhub `viktorstrate/photoview:266-panic`, please try that one, it should print `!!! PROCESSING VIDEO RIGHT BEFORE POTENTIAL PANIC !!!` along with some details right before...

I accidentally used `log.Panicf` instead of `log.Printf` 🙃 I've pushed an update, would you mind pulling `viktorstrate/photoview:266-panic` again and retry.

> log.Panicf(0xec2278, 0x5b, 0xc00191da20, 0x2, 0x2) It still looks like it's using the `log.Panicf` build instead of the new one are you sure you've pulled the new one? Try this...

Ha okay, could be a bug on an older version, you can try to check that you are on the latest version or use the "edge" tag for the latest...

Can anyone reproduce this in a controlled environment? Is it specific video files that causes the crash? Could this have been re-introduced in the latest release (2.3.6) or is it...

I think it might be simple to add a condition that checks if `webMetadata` is nil here: https://github.com/photoview/photoview/blob/04d06da8621ea6b9930aa9d8dce8ee1e9c6eb1e5/api/scanner/process_video.go#L97-L100 Bug I'd like to verify it as that is a little strange...