diffkemp icon indicating copy to clipboard operation
diffkemp copied to clipboard

Cannot handle comparing globals with different names in the compared versions

Open viktormalik opened this issue 6 years ago • 0 comments

This situation may occur when analysing differences in module parameters using DiffKemp. If both modules use a different global variable to represent the same parameter (this can be achieved if the modules specify the parameter using module_param_named), DiffKemp will fail since it will try to find the global variable from the first module in the second module as well.

This can be fixed by passing two globals for individual modules to modules_diff, functions_diff, and subsequently to SimpLL as well.

The issue can be reproduced by:

bin/diffkemp 3.10 4.11 drivers/net/wireless/ath/ath9k -m ath9k -p blink

viktormalik avatar Apr 18 '19 06:04 viktormalik